Differential D8402

conftest: Refactor GraphServerProcess to be more flexible
ClosedPublic
Actions

Authored by vlorentz on Sep 6 2022, 5:03 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Maniphest Tasks

T4497: [sentry] Out of disk space

Commits

rDGRPH81d3deb2f1c1: conftest: Refactor GraphServerProcess to be more flexible

Summary

queue is now encapsulated
object in the queue is now a dict instead of a tuple (to allow adding more keys easily in the future + for readability)

This will be used in a future commit (which will address T4497),
to get the queue's object twice from different functions.

Diff Detail

Repository

rDGRPH Compressed graph representation

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31357
Build 49053: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 49052: arc lint + arc unit

Event Timeline

vlorentz created this revision.Sep 6 2022, 5:03 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 6 2022, 5:03 PM

Build has FAILED

Patch application report for D8402 (id=30322)

Rebasing onto dd88f177c3...

Current branch diff-target is up to date.

Changes applied before test

commit 2104133e41a924cf7d2678ac829b5bee44ba2138
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 6 17:02:22 2022 +0200

    conftest: Refactor GraphServerProcess to be more flexible
    
    1. queue is now encapsulated
    2. object in the queue is now a dict instead of a tuple (to allow
       adding more keys easily in the future + for readability)
    
    This will be used in a future commit, to get the queue's object
    twice from different functions.

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/218/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/218/console

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 6 2022, 5:10 PM

Harbormaster failed remote builds in B31350: Diff 30322!

vlorentz added a child revision: D8403: Kill GraphServerProcess on test teardown.Sep 6 2022, 5:15 PM

move hunks around

Build has FAILED

Patch application report for D8402 (id=30325)

Rebasing onto dd88f177c3...

Current branch diff-target is up to date.

Changes applied before test

commit 46255335308446d7b077099fd9b1c68726faf140
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 6 17:02:22 2022 +0200

    conftest: Refactor GraphServerProcess to be more flexible
    
    1. queue is now encapsulated
    2. object in the queue is now a dict instead of a tuple (to allow
       adding more keys easily in the future + for readability)
    
    This will be used in a future commit, to get the queue's object
    twice from different functions.

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/221/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/221/console

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 6 2022, 5:25 PM

Harbormaster failed remote builds in B31353: Diff 30325!

meh

vlorentz added a task: T4497: [sentry] Out of disk space.Sep 6 2022, 5:31 PM

Build is green

Patch application report for D8402 (id=30329)

Rebasing onto dd88f177c3...

Current branch diff-target is up to date.

Changes applied before test

commit 81d3deb2f1c1b584a076484250cb6f349009f032
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 6 17:02:22 2022 +0200

    conftest: Refactor GraphServerProcess to be more flexible
    
    1. queue is now encapsulated
    2. object in the queue is now a dict instead of a tuple (to allow
       adding more keys easily in the future + for readability)
    
    This will be used in a future commit, to get the queue's object
    twice from different functions.

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/224/ for more details.

Harbormaster completed remote builds in B31357: Diff 30329.Sep 6 2022, 5:34 PM

vlorentz requested review of this revision.Sep 6 2022, 5:34 PM