Page MenuHomeSoftware Heritage
Differential D8182

cassandra: Simplify SELECT statement formatting
ClosedPublic
Actions

Authored by vlorentz on Aug 4 2022, 1:51 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSTO0aff46189a13: cassandra: Simplify SELECT statement formatting
Test Plan

Failures of release_add_arbitrary will be solved by D8184; failures of directory_add_arbitrary are unrelated

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 4 2022, 1:51 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 4 2022, 1:51 PM
vlorentz added a child revision: D8183: Stop using `USE <keyspace>` with prepared statements.Aug 4 2022, 1:55 PM
swh-public-ci added a comment.Aug 4 2022, 2:06 PM

Build has FAILED

Patch application report for D8182 (id=29541)

Rebasing onto 2205fa6e1f...

Current branch diff-target is up to date.
Changes applied before test
commit 0aff46189a13e9f1d1d65418faa99ac1dc33d461
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 4 13:51:16 2022 +0200

    cassandra: Simplify SELECT statement formatting

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1638/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1638/console

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 4 2022, 2:06 PM
Harbormaster failed remote builds in B30608: Diff 29541!
swh-public-ci added a comment.Aug 4 2022, 2:25 PM

Build has FAILED

Patch application report for D8182 (id=29541)

Rebasing onto 2205fa6e1f...

Current branch diff-target is up to date.
Changes applied before test
commit 0aff46189a13e9f1d1d65418faa99ac1dc33d461
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 4 13:51:16 2022 +0200

    cassandra: Simplify SELECT statement formatting

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1640/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1640/console

vlorentz requested review of this revision.Aug 4 2022, 2:38 PM
vlorentz edited the test plan for this revision. (Show Details)
ardumont accepted this revision.Aug 4 2022, 5:30 PM
ardumont added a subscriber: ardumont.

lgtm

one question inline.

swh/storage/cassandra/cql.py
1172

you sure on this one?
It used to query the snapshot table.

This revision is now accepted and ready to land.Aug 4 2022, 5:30 PM
vlorentz added inline comments.Aug 4 2022, 6:10 PM
swh/storage/cassandra/cql.py
1172

it used to query the snapshot field of the origin_visit_status table, and still does

This revision was landed with ongoing or failed builds.Aug 5 2022, 10:06 AM
Closed by commit rDSTO0aff46189a13: cassandra: Simplify SELECT statement formatting (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDSTO0aff46189a13: cassandra: Simplify SELECT statement formatting.

Revision Contents
Changeset List

PathSize
swh/
storage/
cassandra/
27 lines

Diff 29563

View Options

swh/storage/cassandra/cql.py

Loading...
About · Developer information · Legal