cassandra: Simplify SELECT statement formatting
ClosedPublic
Actions

Authored by vlorentz on Aug 4 2022, 1:51 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSTO0aff46189a13: cassandra: Simplify SELECT statement formatting

Test Plan

Failures of release_add_arbitrary will be solved by D8184; failures of directory_add_arbitrary are unrelated

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 30608
Build 47857: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 47856: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	1,595 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.tests.test_postgresql.TestStorage::test_directory_add_get_arbitrary self = <hypothesis.core.StateForActualGivenExecution object at 0x7fc0ad356b70> data = ConjectureData(INTERESTING, 209 bytes, frozen)
	2,795 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.tests.test_postgresql.TestStorage::test_release_add_get_arbitrary self = <swh.storage.tests.test_postgresql.TestStorage object at 0x7fc30cc705c0> swh_storage = <swh.storage.postgresql.storage.Storage object at 0x7fc0ad3b4630>
	114,274 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.tests.test_postgresql_flavor_mirror.TestStorage::test_directory_add_get_arbitrary self = <swh.storage.tests.test_postgresql.TestStorage object at 0x7fc30c67d828> swh_storage = <swh.storage.postgresql.storage.Storage object at 0x7fc0e2616550>
	2,601 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.tests.test_postgresql_flavor_mirror.TestStorage::test_release_add_get_arbitrary self = <swh.storage.tests.test_postgresql.TestStorage object at 0x7fc30c3df7b8> swh_storage = <swh.storage.postgresql.storage.Storage object at 0x7fc0af668e10>
	2,006 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.tests.test_postgresql_flavor_readreplica.TestStorage::test_directory_add_get_arbitrary self = <swh.storage.tests.test_postgresql.TestStorage object at 0x7fc30c5c3048> swh_storage = <swh.storage.postgresql.storage.Storage object at 0x7fc11e76dac8>
		View Full Test Results (7 Failed · 1,604 Passed · 44 Skipped)

Event Timeline

vlorentz created this revision.Aug 4 2022, 1:51 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 4 2022, 1:51 PM

vlorentz added a child revision: D8183: Stop using `USE <keyspace>` with prepared statements.Aug 4 2022, 1:55 PM

Build has FAILED

Patch application report for D8182 (id=29541)

Rebasing onto 2205fa6e1f...

Current branch diff-target is up to date.

Changes applied before test

commit 0aff46189a13e9f1d1d65418faa99ac1dc33d461
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 4 13:51:16 2022 +0200

    cassandra: Simplify SELECT statement formatting

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1638/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1638/console

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 4 2022, 2:06 PM

Harbormaster failed remote builds in B30608: Diff 29541!

Build has FAILED

Patch application report for D8182 (id=29541)

Rebasing onto 2205fa6e1f...

Current branch diff-target is up to date.

Changes applied before test

commit 0aff46189a13e9f1d1d65418faa99ac1dc33d461
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 4 13:51:16 2022 +0200

    cassandra: Simplify SELECT statement formatting

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1640/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1640/console

vlorentz requested review of this revision.Aug 4 2022, 2:38 PM

vlorentz edited the test plan for this revision. (Show Details)