Differential D8184

hypothesis_strategies: Avoid generating timestamps which overflow datetime.datetime.fromtimestamp
ClosedPublic
Actions

Authored by vlorentz on Aug 4 2022, 2:37 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDMOD79ed55054633: hypothesis_strategies: Avoid generating timestamps which overflow datetime.

Summary

Depends on D8186 (to fix an unrelated bug)

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 4 2022, 2:37 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 4 2022, 2:37 PM

Build has FAILED

Patch application report for D8184 (id=29543)

Rebasing onto b872718ab4...

Current branch diff-target is up to date.

Changes applied before test

commit 022256f6d63be882bcf61d7d45981fd9c6ca4acc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 4 14:36:47 2022 +0200

    hypothesis_strategies: Avoid generating timestamps which overflow datetime.datetime.fromtimestamp

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/494/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/494/console

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 4 2022, 2:37 PM

Harbormaster failed remote builds in B30610: Diff 29543!

vlorentz mentioned this in D8182: cassandra: Simplify SELECT statement formatting.Aug 4 2022, 2:38 PM

vlorentz requested review of this revision.Aug 4 2022, 2:40 PM

vlorentz edited the test plan for this revision. (Show Details)

rebase to fix mypy error

vlorentz edited the summary of this revision. (Show Details)Aug 4 2022, 2:53 PM

vlorentz edited the test plan for this revision. (Show Details)

vlorentz added a parent revision: D8186: Fix mypy error on attr >= 22.1.0.

Build is green

Patch application report for D8184 (id=29546)

Could not rebase; Attempt merge onto b872718ab4...

Updating b872718..79ed550
Fast-forward
 swh/model/hypothesis_strategies.py | 12 ++++++++++++
 swh/model/model.py                 |  4 +++-
 2 files changed, 15 insertions(+), 1 deletion(-)

Changes applied before test

commit 79ed55054633fd4484d7bc6b26e64432ad3492cf
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 4 14:36:47 2022 +0200

    hypothesis_strategies: Avoid generating timestamps which overflow datetime.datetime.fromtimestamp

commit c37bf9a1bb41d9940538ba471d5c6d39f37ff0cf
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 4 14:52:43 2022 +0200

    Fix mypy error on attr >= 22.1.0

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/496/ for more details.

Harbormaster completed remote builds in B30613: Diff 29546.Aug 4 2022, 2:56 PM

ardumont accepted this revision.Aug 4 2022, 4:05 PM

This revision is now accepted and ready to land.Aug 4 2022, 4:05 PM

Closed by commit rDMOD79ed55054633: hypothesis_strategies: Avoid generating timestamps which overflow datetime. (authored by vlorentz). · Explain WhyAug 4 2022, 4:24 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDMOD79ed55054633: hypothesis_strategies: Avoid generating timestamps which overflow datetime..