Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Required Signatures
L3 Software Heritage Contributor License Agreement, version 1.0
Diff Detail
- Repository
- rDWAPPS Web applications
- Branch
- add-tooltip-to-request-now-status
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 29039 Build 45396: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 45395: arc lint + arc unit
Event Timeline
hey there, I added a tooltip. and it doesn't seem to work. can you please guide me on what am I doing wrong.
Build has FAILED
Patch application report for D7537 (id=27329)
Rebasing onto d35ba5194f...
First, rewinding head to replay your work on top of it... Applying: Add tooltip to add forge now request status
Changes applied before test
commit a3acd6387cf94f2a39430a0e903d0cc28c88ca15
Author: pranay101 <pranayprajapati101@gmail.com>
Date: Fri Apr 8 16:54:49 2022 +0530
Add tooltip to add forge now request statusLink to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1703/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1703/console
You should have been able to find examples of tooltips use with datatables through a simple google search,
for instance I found this one in the first results.
Also we need to provide to you the text of the tooltips for each request status.
Until then, try to make the tooltip work in the first place and add a new cypress test in
cypress/integration/add-forge-now-requests-moderation.spec.js
checking tooltip is displayed when hovering the mouse on a request status in the table.
| assets/src/bundles/add_forge/moderation-dashboard.js | ||
|---|---|---|
| 18 ↗ | (On Diff #27329) | Why activating the bootstrap tooltips in the error callback ? This should be removed. |
| 23 ↗ | (On Diff #27329) | there is no such option for datatables, you can remove it. |
Until then, try to make the tooltip work in the first place and add a new cypress test in
cypress/integration/add-forge-now-requests-moderation.spec.js
checking tooltip is displayed when hovering the mouse on a request status in the table.
To execute cypress UI, execute make test-frontend-ui in swh-web source root directory.
To simulate a mouse over event and check tooltip is displayed, you can inspire from that cypress code snippet.
Build is green
Patch application report for D7537 (id=27961)
Rebasing onto d9fb8522ed...
Current branch diff-target is up to date.
Changes applied before test
commit 62cd93501f97988b3e605714b5432f593a0b1f9f
Author: pranay101 <pranayprajapati101@gmail.com>
Date: Tue May 3 22:14:12 2022 +0530
Made the static tooltip workSee https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1777/ for more details.
@pranay101 For this to land is not only about making it work, you need to attend to anlambert's remark as well [1]
[1] D7537#196909