Page MenuHomeSoftware Heritage
Differential D7537

Add tooltip to add forge now request status
Needs RevisionPublic
Actions

Authored by pranay101 on Apr 8 2022, 1:31 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Required Signatures
L3 Software Heritage Contributor License Agreement, version 1.0

Diff Detail

Repository
rDWAPPS Web applications
Branch
add-tooltip-to-request-now-status
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 28261
Build 44246: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 44245: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
6,395 msJenkins > should show only user requests when filter is activated::Tests / Cypress tests / Run cypress tests / Origin Save Tests should show only user requests when filter is activated
AssertionError: expected 3 to equal 2 at Context.eval (http://localhost:5004/__cypress/tests?p=cypress/integration/origin-save.spec.js:575:30)
652 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.add_forge_now.test_migration::Tests / Python tests / test_add_forge_now_allow_no_comment
453 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.add_forge_now.test_migration::Tests / Python tests / test_add_forge_now_initial_migration
453 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.add_forge_now.test_migration::Tests / Python tests / test_add_forge_now_store_submitter_forward_username
179 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.add_forge_now.test_models::Tests / Python tests / test_allowed_next_statuses[RequestStatus.PENDING-allowed_next_statuses0]
View Full Test Results (1 Failed · 962 Passed · 5 Skipped)

Event Timeline

pranay101 created this revision.Apr 8 2022, 1:31 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 8 2022, 1:31 PM
Herald added a required legal document: L3 Software Heritage Contributor License Agreement, version 1.0. · View Herald Transcript
pranay101 added a comment.Apr 8 2022, 1:38 PM

hey there, I added a tooltip. and it doesn't seem to work. can you please guide me on what am I doing wrong.

swh-public-ci added a comment.Apr 8 2022, 1:58 PM

Build has FAILED

Patch application report for D7537 (id=27329)

Rebasing onto d35ba5194f...

First, rewinding head to replay your work on top of it...
Applying: Add tooltip to add forge now request status
Changes applied before test
commit a3acd6387cf94f2a39430a0e903d0cc28c88ca15
Author: pranay101 <pranayprajapati101@gmail.com>
Date:   Fri Apr 8 16:54:49 2022 +0530

    Add tooltip to add forge now request status

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1703/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1703/console

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 8 2022, 1:58 PM
Harbormaster failed remote builds in B28261: Diff 27329!
anlambert added a subscriber: anlambert.Apr 8 2022, 2:25 PM
In D7537#196896, @pranay101 wrote:

hey there, I added a tooltip. and it doesn't seem to work. can you please guide me on what am I doing wrong.

You should have been able to find examples of tooltips use with datatables through a simple google search,
for instance I found this one in the first results.

Also we need to provide to you the text of the tooltips for each request status.

Until then, try to make the tooltip work in the first place and add a new cypress test in
cypress/integration/add-forge-now-requests-moderation.spec.js
checking tooltip is displayed when hovering the mouse on a request status in the table.

assets/src/bundles/add_forge/moderation-dashboard.js
18

Why activating the bootstrap tooltips in the error callback ? This should be removed.

23

there is no such option for datatables, you can remove it.

anlambert added a comment.Apr 8 2022, 3:03 PM

Until then, try to make the tooltip work in the first place and add a new cypress test in
cypress/integration/add-forge-now-requests-moderation.spec.js
checking tooltip is displayed when hovering the mouse on a request status in the table.

To execute cypress UI, execute make test-frontend-ui in swh-web source root directory.
To simulate a mouse over event and check tooltip is displayed, you can inspire from that cypress code snippet.

pranay101 updated this revision to Diff 27961.May 3 2022, 6:50 PM
pranay101 marked an inline comment as done.

Made the static tooltip work

swh-public-ci added a comment.May 3 2022, 7:10 PM

Build is green

Patch application report for D7537 (id=27961)

Rebasing onto d9fb8522ed...

Current branch diff-target is up to date.
Changes applied before test
commit 62cd93501f97988b3e605714b5432f593a0b1f9f
Author: pranay101 <pranayprajapati101@gmail.com>
Date:   Tue May 3 22:14:12 2022 +0530

    Made the static tooltip work

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1777/ for more details.

Harbormaster completed remote builds in B29039: Diff 27961.May 3 2022, 7:10 PM
pranay101 requested review of this revision.May 3 2022, 7:10 PM
ardumont added a subscriber: ardumont.May 25 2022, 2:24 PM

@pranay101 For this to land is not only about making it work, you need to attend to anlambert's remark as well [1]

[1] D7537#196909

vlorentz requested changes to this revision.Jun 1 2022, 9:26 AM
This revision now requires changes to proceed.Jun 1 2022, 9:26 AM

Revision Contents
Changeset List

PathSize
assets/
src/
bundles/
add_forge/
4 lines

Diff 27329

View Options

assets/src/bundles/add_forge/moderation-dashboard.js

Loading...
About · Developer information · Legal