Add missing Sentry Captures
ClosedPublic
Actions

Authored by bchauvet on Apr 14 2022, 11:37 AM.

Details

Reviewers

anlambert
vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T3957: Clean sentry reports

Commits

rDLDBASE272b5aac064e: Add missing Sentry Captures

Summary

related to T3957

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 28994
Build 45329: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 45328: arc lint + arc unit

Event Timeline

bchauvet created this revision.Apr 14 2022, 11:37 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 14 2022, 11:37 AM

Build is green

Patch application report for D7576 (id=27444)

Rebasing onto 255f3b2858...

Current branch diff-target is up to date.

Changes applied before test

commit 2d10c4ae678be59546418c674710038bb6c6fdbd
Author: Benoit Chauvet <contact@benoitchauvet.com>
Date:   Thu Apr 14 11:33:57 2022 +0200

    Add missing Sentry Captures

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/717/ for more details.

Harbormaster completed remote builds in B28459: Diff 27444.Apr 14 2022, 11:40 AM

bchauvet requested review of this revision.Apr 14 2022, 11:40 AM

anlambert accepted this revision.Apr 14 2022, 1:45 PM

This revision is now accepted and ready to land.Apr 14 2022, 1:45 PM

We should add sentry captures in swh/loader/core/loader.py too, after each of the two except Exception

This revision now requires changes to proceed.Apr 19 2022, 3:25 PM

Add missing sentry Captures

This revision was not accepted when it landed; it landed in state Needs Review.May 2 2022, 1:37 PM

This revision was landed with ongoing or failed builds.

Closed by commit rDLDBASE272b5aac064e: Add missing Sentry Captures (authored by bchauvet). · Explain Why

This revision was automatically updated to reflect the committed changes.

bchauvet added a commit: rDLDBASE272b5aac064e: Add missing Sentry Captures.

Build has FAILED

Patch application report for D7576 (id=27930)

Rebasing onto f07890bc0c...

Current branch diff-target is up to date.

Changes applied before test

commit 272b5aac064e8d5811f94d696fc8cefffed2f0a7
Author: Benoit Chauvet <contact@benoitchauvet.com>
Date:   Thu Apr 14 11:33:57 2022 +0200

    Add missing Sentry Captures

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/761/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/761/console

Harbormaster failed remote builds in B28994: Diff 27930!May 2 2022, 1:38 PM