Page MenuHomeSoftware Heritage

Add missing Sentry Captures
ClosedPublic

Authored by bchauvet on Apr 14 2022, 11:37 AM.

Details

Summary

related to T3957

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D7576 (id=27444)

Rebasing onto 255f3b2858...

Current branch diff-target is up to date.
Changes applied before test
commit 2d10c4ae678be59546418c674710038bb6c6fdbd
Author: Benoit Chauvet <contact@benoitchauvet.com>
Date:   Thu Apr 14 11:33:57 2022 +0200

    Add missing Sentry Captures

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/717/ for more details.

This revision is now accepted and ready to land.Apr 14 2022, 1:45 PM
vlorentz added a subscriber: vlorentz.

We should add sentry captures in swh/loader/core/loader.py too, after each of the two except Exception

This revision now requires changes to proceed.Apr 19 2022, 3:25 PM

Add missing sentry Captures

This revision was not accepted when it landed; it landed in state Needs Review.May 2 2022, 1:37 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.

Build has FAILED

Patch application report for D7576 (id=27930)

Rebasing onto f07890bc0c...

Current branch diff-target is up to date.
Changes applied before test
commit 272b5aac064e8d5811f94d696fc8cefffed2f0a7
Author: Benoit Chauvet <contact@benoitchauvet.com>
Date:   Thu Apr 14 11:33:57 2022 +0200

    Add missing Sentry Captures

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/761/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/761/console