moderation: Fix deposit uri computation for 'code' deposits
ClosedPublic
Actions

Authored by ardumont on Apr 1 2022, 4:39 PM.

Details

Reviewers

moranegg
vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T4123: Change uri in deposit admin view

Commits

rDWAPPS8ffd81760aa9: moderation: Fix deposit uri computation for 'code' deposits

Summary

Prior to this commit, this was done for all deposits but it's only a good fallback for
typed deposit 'code'.

Related to T4123

Test Plan

tox

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 28070
Build 43960: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 43959: arc lint + arc unit

Event Timeline

ardumont created this revision.Apr 1 2022, 4:39 PM

Better implementation, it could be that raw_provenance is not provided so we need to
account for that nonetheless.

Explicit how the uri is computed

Build is green

Patch application report for D7486 (id=27153)

Rebasing onto ad5add7d36...

Current branch diff-target is up to date.

Changes applied before test

commit 96772318471a05fe360ebfd2da4772ef8ad16a2d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Apr 1 16:37:42 2022 +0200

    moderation: Fix deposit uri computation for 'code' deposits
    
    Prior to this commit, this was done for all deposits but it's only a good fallback for
    typed deposit 'code'.
    
    Related to T4123

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1645/ for more details.

Harbormaster completed remote builds in B28069: Diff 27153.Apr 1 2022, 5:00 PM

Build is green

Patch application report for D7486 (id=27154)

Rebasing onto ad5add7d36...

Current branch diff-target is up to date.

Changes applied before test

commit e05391bd248bf601c27822b1a7633579eb263c9d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Apr 1 16:37:42 2022 +0200

    moderation: Fix deposit uri computation for 'code' deposits
    
    Prior to this commit, this was done for all deposits but it's only a good fallback for
    typed deposit 'code'.
    
    Related to T4123

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1646/ for more details.

Harbormaster completed remote builds in B28070: Diff 27154.Apr 1 2022, 5:04 PM

Build is green

Patch application report for D7486 (id=27155)

Rebasing onto ad5add7d36...

Current branch diff-target is up to date.

Changes applied before test

commit 8ffd81760aa971773b693a07934d717dfaf91b22
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Apr 1 16:37:42 2022 +0200

    moderation: Fix deposit uri computation for 'code' deposits
    
    Prior to this commit, this was done for all deposits but it's only a good fallback for
    typed deposit 'code'.
    
    Related to T4123

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1647/ for more details.

Harbormaster completed remote builds in B28071: Diff 27155.Apr 1 2022, 5:07 PM

ardumont requested review of this revision.Apr 1 2022, 5:08 PM

vlorentz accepted this revision.Apr 4 2022, 10:15 AM

This revision is now accepted and ready to land.Apr 4 2022, 10:15 AM

Closed by commit rDWAPPS8ffd81760aa9: moderation: Fix deposit uri computation for 'code' deposits (authored by ardumont). · Explain WhyApr 4 2022, 12:48 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDWAPPS8ffd81760aa9: moderation: Fix deposit uri computation for 'code' deposits.