Page MenuHomeSoftware Heritage

Reference the new swh.scrubber module
ClosedPublic

Authored by ardumont on Mar 29 2022, 9:35 AM.

Details

Summary

This should help alleviate problem in the new roadmap diff [1].

[1] D7445

Related to D7445

Test Plan

Build will fail due to D7447 and D7446 not landed yet

Diff Detail

Event Timeline

Build has FAILED

Patch application report for D7448 (id=26958)

Rebasing onto f6e7503224...

Current branch diff-target is up to date.
Changes applied before test
commit 374a1f5112e52344fa9964599365239b082abc03
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:33:46 2022 +0200

    Reference the new swh.scrubber module

Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/127/
See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/127/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 29 2022, 9:50 AM
Harbormaster failed remote builds in B27874: Diff 26958!

Should be before swh.search.

And here is a better description:

Tooling to check integrity of various data stores (swh.journal, swh.objstorage, swh.storage)
and fix corrupt objects they contain.

Should be before swh.search.

d'oh right ;)

And here is a better description:

Tooling to check integrity of various data stores (swh.journal, swh.objstorage, swh.storage)
and fix corrupt objects they contain.

Thanks!

ardumont edited the test plan for this revision. (Show Details)

Adapt according to val's suggestion (build will still fail for unrelated reasons i'm
working on)

Build has FAILED

Patch application report for D7448 (id=27026)

Rebasing onto f6e7503224...

Current branch diff-target is up to date.
Changes applied before test
commit ac803050738649c76cb2fbd86f36bda9021fd00e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:33:46 2022 +0200

    Reference the new swh.scrubber module

Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/129/
See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/129/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 29 2022, 5:22 PM
Harbormaster failed remote builds in B27942: Diff 27026!

Build has FAILED

Patch application report for D7448 (id=27060)

Rebasing onto f6e7503224...

Current branch diff-target is up to date.
Changes applied before test
commit ac803050738649c76cb2fbd86f36bda9021fd00e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:33:46 2022 +0200

    Reference the new swh.scrubber module

Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/131/
See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/131/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2022, 9:51 AM
Harbormaster failed remote builds in B27977: Diff 27060!

Build has FAILED

Patch application report for D7448 (id=27060)

Rebasing onto f6e7503224...

Current branch diff-target is up to date.
Changes applied before test
commit ac803050738649c76cb2fbd86f36bda9021fd00e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:33:46 2022 +0200

    Reference the new swh.scrubber module

Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/132/
See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/132/console

Build has FAILED

Patch application report for D7448 (id=27060)

Rebasing onto f6e7503224...

Current branch diff-target is up to date.
Changes applied before test
commit ac803050738649c76cb2fbd86f36bda9021fd00e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:33:46 2022 +0200

    Reference the new swh.scrubber module

Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/133/
See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/133/console

Add missing requirement upgrade on swh-scrubber module

Build is green

Patch application report for D7448 (id=27090)

Rebasing onto 85bcc15b26...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-30-D7448.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DSCRUB/job/tests-on-diff/30/ for more details.

Use correct repository and add missing scrubber requirements

Build is green

What a nice cheat ;) I've updated the diff with the right commit range on the wrong repository so the build got green, which published the diff...
It's not ready yet as there is still an ongoing mess to untangle with the model doc part... (i thought it was fixed but not yet...)

Build has FAILED

Patch application report for D7448 (id=27091)

Rebasing onto f6e7503224...

Current branch diff-target is up to date.
Changes applied before test
commit 75c2d3b3ee9ef26d6bda2b832ef362e86477a72d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:33:46 2022 +0200

    Reference the new swh.scrubber module

Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/134/
See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/134/console

Build has FAILED

12:14:51  /var/lib/jenkins/workspace/DDOC/build-on-diff/swh-docs/docs/swh-model/cli.rst:14: WARNING: Literal block expected; none found.

Remains this one on model to fix but i don't get it.

12:14:51  /var/lib/jenkins/workspace/DDOC/build-on-diff/swh-docs/docs/swh-scrubber/index.rst: WARNING: document isn't included in any toctree

Liar liar, pants on fire! That's what this diff is all about... (T.T)

12:14:51  /var/lib/jenkins/workspace/DDOC/build-on-diff/swh-docs/docs/swh-scrubber/index.rst: WARNING: document isn't included in any toctree

Liar liar, pants on fire! That's what this diff is all about... (T.T)

No, it's correct. You added a reference, but it still not in any toctree.

You need to add it to swh-docs/docs/api-reference.rst

Real final say: 'jenkins, go green!' (with the right repo)

Build is green

Patch application report for D7448 (id=27095)

Rebasing onto 85bcc15b26...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-31-D7448.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DSCRUB/job/tests-on-diff/31/ for more details.

12:14:51  /var/lib/jenkins/workspace/DDOC/build-on-diff/swh-docs/docs/swh-scrubber/index.rst: WARNING: document isn't included in any toctree

Liar liar, pants on fire! That's what this diff is all about... (T.T)

No, it's correct. You added a reference, but it still not in any toctree.

You need to add it to swh-docs/docs/api-reference.rst

Thanks! I think it'd be nice if we reference that commit (once it's landed) in the add a new module documentation page...

Build has FAILED

Patch application report for D7448 (id=27091)

Rebasing onto f6e7503224...

Current branch diff-target is up to date.
Changes applied before test
commit 75c2d3b3ee9ef26d6bda2b832ef362e86477a72d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:33:46 2022 +0200

    Reference the new swh.scrubber module

Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/135/
See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/135/console

Build has FAILED

Patch application report for D7448 (id=27096)

Rebasing onto f6e7503224...

Current branch diff-target is up to date.
Changes applied before test
commit f6cbf42ad1d961b35fa13d33ee07ef3c346dcf1b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:33:46 2022 +0200

    Reference the new swh.scrubber module

Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/136/
See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/136/console

Build has FAILED

12:48:14  /var/lib/jenkins/workspace/DDOC/build-on-diff@2/swh-docs/docs/swh-model/cli.rst:14: WARNING: Literal block expected; none found.

Back to that last one!

that's a bug in click, but no idea how to debug that...

Build has FAILED

Patch application report for D7448 (id=27096)

Rebasing onto f6e7503224...

Current branch diff-target is up to date.
Changes applied before test
commit f6cbf42ad1d961b35fa13d33ee07ef3c346dcf1b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:33:46 2022 +0200

    Reference the new swh.scrubber module

Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/137/
See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/137/console

Trigger build after last swh-model change (to tentatively fix that last warning...)

Build has FAILED

Patch application report for D7448 (id=27103)

Rebasing onto f6e7503224...

Current branch diff-target is up to date.
Changes applied before test
commit f6cbf42ad1d961b35fa13d33ee07ef3c346dcf1b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:33:46 2022 +0200

    Reference the new swh.scrubber module

Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/139/
See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/139/console

Used docker to try and reproduce and i don't, trigger the build again...

Build has FAILED

Patch application report for D7448 (id=27115)

Rebasing onto f6e7503224...

Current branch diff-target is up to date.
Changes applied before test
commit f6cbf42ad1d961b35fa13d33ee07ef3c346dcf1b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:33:46 2022 +0200

    Reference the new swh.scrubber module

Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/141/
See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/141/console

This revision was not accepted when it landed; it landed in state Needs Review.Mar 30 2022, 6:29 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.