Page MenuHomeSoftware Heritage
Differential D7448

Reference the new swh.scrubber module
ClosedPublic
Actions

Authored by ardumont on Mar 29 2022, 9:35 AM.

Details

Reviewers
None
Group Reviewers
Reviewers
Maniphest Tasks
T4120: Fix documentation dev build (again)
Commits
rDDOCf6cbf42ad1d9: Reference the new swh.scrubber module
Summary

This should help alleviate problem in the new roadmap diff [1].

[1] D7445

Related to D7445

Test Plan

Build will fail due to D7447 and D7446 not landed yet

Diff Detail

Repository
rDSCRUB Datastore Scrubber
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 28013
Build 43873: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 43872: arc lint + arc unit

Event Timeline

ardumont created this revision.Mar 29 2022, 9:35 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 29 2022, 9:35 AM
ardumont mentioned this in D7445: roadmap 2022 documentation.Mar 29 2022, 9:38 AM
swh-public-ci added a comment.Mar 29 2022, 9:50 AM

Build has FAILED

Patch application report for D7448 (id=26958)

Rebasing onto f6e7503224...

Current branch diff-target is up to date.
Changes applied before test
commit 374a1f5112e52344fa9964599365239b082abc03
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:33:46 2022 +0200

    Reference the new swh.scrubber module

Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/127/
See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/127/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 29 2022, 9:50 AM
Harbormaster failed remote builds in B27874: Diff 26958!
ardumont edited the test plan for this revision. (Show Details)Mar 29 2022, 12:15 PM
vlorentz added a subscriber: vlorentz.Mar 29 2022, 4:30 PM

Should be before swh.search.

And here is a better description:

Tooling to check integrity of various data stores (swh.journal, swh.objstorage, swh.storage)
and fix corrupt objects they contain.
ardumont added a comment.Mar 29 2022, 5:04 PM

Should be before swh.search.

d'oh right ;)

And here is a better description:

Tooling to check integrity of various data stores (swh.journal, swh.objstorage, swh.storage)
and fix corrupt objects they contain.

Thanks!

ardumont updated this revision to Diff 27026.Mar 29 2022, 5:07 PM
ardumont edited the test plan for this revision. (Show Details)

Adapt according to val's suggestion (build will still fail for unrelated reasons i'm
working on)

swh-public-ci added a comment.Mar 29 2022, 5:22 PM

Build has FAILED

Patch application report for D7448 (id=27026)

Rebasing onto f6e7503224...

Current branch diff-target is up to date.
Changes applied before test
commit ac803050738649c76cb2fbd86f36bda9021fd00e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:33:46 2022 +0200

    Reference the new swh.scrubber module

Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/129/
See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/129/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 29 2022, 5:22 PM
Harbormaster failed remote builds in B27942: Diff 27026!
ardumont updated this revision to Diff 27060.Mar 30 2022, 9:35 AM

Trigger build

swh-public-ci added a comment.Mar 30 2022, 9:51 AM

Build has FAILED

Patch application report for D7448 (id=27060)

Rebasing onto f6e7503224...

Current branch diff-target is up to date.
Changes applied before test
commit ac803050738649c76cb2fbd86f36bda9021fd00e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:33:46 2022 +0200

    Reference the new swh.scrubber module

Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/131/
See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/131/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2022, 9:51 AM
Harbormaster failed remote builds in B27977: Diff 27060!
ardumont mentioned this in D7466: docs/cli: Align cli documentation toc setup.Mar 30 2022, 10:19 AM
ardumont mentioned this in D7467: docs/cli: Align cli documentation toc setup.Mar 30 2022, 11:03 AM
swh-public-ci added a comment.Mar 30 2022, 11:25 AM

Build has FAILED

Patch application report for D7448 (id=27060)

Rebasing onto f6e7503224...

Current branch diff-target is up to date.
Changes applied before test
commit ac803050738649c76cb2fbd86f36bda9021fd00e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:33:46 2022 +0200

    Reference the new swh.scrubber module

Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/132/
See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/132/console

swh-public-ci added a comment.Mar 30 2022, 11:52 AM

Build has FAILED

Patch application report for D7448 (id=27060)

Rebasing onto f6e7503224...

Current branch diff-target is up to date.
Changes applied before test
commit ac803050738649c76cb2fbd86f36bda9021fd00e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:33:46 2022 +0200

    Reference the new swh.scrubber module

Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/133/
See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/133/console

ardumont updated this revision to Diff 27090.Mar 30 2022, 11:57 AM

Add missing requirement upgrade on swh-scrubber module

swh-public-ci added a comment.Mar 30 2022, 12:00 PM

Build is green

Patch application report for D7448 (id=27090)

Rebasing onto 85bcc15b26...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-30-D7448.
Changes applied before test



See https://jenkins.softwareheritage.org/job/DSCRUB/job/tests-on-diff/30/ for more details.
Harbormaster completed remote builds in B28007: Diff 27090.Mar 30 2022, 12:00 PM
ardumont requested review of this revision.Mar 30 2022, 12:00 PM
ardumont updated this revision to Diff 27091.Mar 30 2022, 12:00 PM
Use correct repository and add missing scrubber requirements
ardumont added a comment.Mar 30 2022, 12:13 PM
Build is green



What a nice cheat ;) I've updated the diff with the right commit range on the wrong repository so the build got green, which published the diff...

It's not ready yet as there is still an ongoing mess to untangle with the model doc part... (i thought it was fixed but not yet...)
swh-public-ci added a comment.Mar 30 2022, 12:16 PM
Build has FAILED



Patch application report for D7448 (id=27091)



Rebasing onto f6e7503224...



Current branch diff-target is up to date.





Changes applied before test



commit 75c2d3b3ee9ef26d6bda2b832ef362e86477a72d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:33:46 2022 +0200

    Reference the new swh.scrubber module



Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/134/

See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/134/console
Harbormaster failed remote builds in B28008: Diff 27091!Mar 30 2022, 12:16 PM
ardumont added a comment.Mar 30 2022, 12:18 PM
Build has FAILED





12:14:51  /var/lib/jenkins/workspace/DDOC/build-on-diff/swh-docs/docs/swh-model/cli.rst:14: WARNING: Literal block expected; none found.



Remains this one on model to fix but i don't get it.



12:14:51  /var/lib/jenkins/workspace/DDOC/build-on-diff/swh-docs/docs/swh-scrubber/index.rst: WARNING: document isn't included in any toctree



Liar liar, pants on fire! That's what this diff is all about... (T.T)
vlorentz added a comment.Mar 30 2022, 12:27 PM


In D7448#195176, @ardumont wrote:


12:14:51  /var/lib/jenkins/workspace/DDOC/build-on-diff/swh-docs/docs/swh-scrubber/index.rst: WARNING: document isn't included in any toctree



Liar liar, pants on fire! That's what this diff is all about... (T.T)





No, it's correct. You added a reference, but it still not in any toctree.



You need to add it to swh-docs/docs/api-reference.rst
ardumont updated this revision to Diff 27095.Mar 30 2022, 12:33 PM
jenkins: go green!
ardumont updated this revision to Diff 27096.Mar 30 2022, 12:34 PM
Real final say: 'jenkins, go green!' (with the right repo)
swh-public-ci added a comment.Mar 30 2022, 12:35 PM
Build is green



Patch application report for D7448 (id=27095)



Rebasing onto 85bcc15b26...



First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-31-D7448.





Changes applied before test






See https://jenkins.softwareheritage.org/job/DSCRUB/job/tests-on-diff/31/ for more details.
Harbormaster completed remote builds in B28013: Diff 27095.Mar 30 2022, 12:35 PM
ardumont added a comment.Mar 30 2022, 12:35 PM
12:14:51  /var/lib/jenkins/workspace/DDOC/build-on-diff/swh-docs/docs/swh-scrubber/index.rst: WARNING: document isn't included in any toctree



Liar liar, pants on fire! That's what this diff is all about... (T.T)



No, it's correct. You added a reference, but it still not in any toctree.



You need to add it to swh-docs/docs/api-reference.rst



Thanks! I think it'd be nice if we reference that commit (once it's landed) in the add a new module documentation page...
swh-public-ci added a comment.Mar 30 2022, 12:42 PM
Build has FAILED



Patch application report for D7448 (id=27091)



Rebasing onto f6e7503224...



Current branch diff-target is up to date.





Changes applied before test



commit 75c2d3b3ee9ef26d6bda2b832ef362e86477a72d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:33:46 2022 +0200

    Reference the new swh.scrubber module



Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/135/

See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/135/console
swh-public-ci added a comment.Mar 30 2022, 12:49 PM
Build has FAILED



Patch application report for D7448 (id=27096)



Rebasing onto f6e7503224...



Current branch diff-target is up to date.





Changes applied before test



commit f6cbf42ad1d961b35fa13d33ee07ef3c346dcf1b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:33:46 2022 +0200

    Reference the new swh.scrubber module



Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/136/

See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/136/console
Harbormaster failed remote builds in B28014: Diff 27096!Mar 30 2022, 12:49 PM
ardumont added a comment.Mar 30 2022, 12:54 PM
Build has FAILED





12:48:14  /var/lib/jenkins/workspace/DDOC/build-on-diff@2/swh-docs/docs/swh-model/cli.rst:14: WARNING: Literal block expected; none found.



Back to that last one!
vlorentz added a comment.Mar 30 2022, 1:16 PM
that's a bug in click, but no idea how to debug that...
ardumont added a child revision: D7471: add-new-package: Update with necessary documentation instructions.Mar 30 2022, 1:17 PM
swh-public-ci added a comment.Mar 30 2022, 1:25 PM
Build has FAILED



Patch application report for D7448 (id=27096)



Rebasing onto f6e7503224...



Current branch diff-target is up to date.





Changes applied before test



commit f6cbf42ad1d961b35fa13d33ee07ef3c346dcf1b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:33:46 2022 +0200

    Reference the new swh.scrubber module



Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/137/

See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/137/console
ardumont updated this revision to Diff 27103.EditedMar 30 2022, 1:33 PM
Trigger build after last swh-model change (to tentatively fix that last warning...)
swh-public-ci added a comment.Mar 30 2022, 1:49 PM
Build has FAILED



Patch application report for D7448 (id=27103)



Rebasing onto f6e7503224...



Current branch diff-target is up to date.





Changes applied before test



commit f6cbf42ad1d961b35fa13d33ee07ef3c346dcf1b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:33:46 2022 +0200

    Reference the new swh.scrubber module



Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/139/

See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/139/console
Harbormaster failed remote builds in B28022: Diff 27103!Mar 30 2022, 1:49 PM
ardumont updated this revision to Diff 27115.Mar 30 2022, 4:15 PM
Used docker to try and reproduce and i don't, trigger the build again...
swh-public-ci added a comment.Mar 30 2022, 4:30 PM
Build has FAILED



Patch application report for D7448 (id=27115)



Rebasing onto f6e7503224...



Current branch diff-target is up to date.





Changes applied before test



commit f6cbf42ad1d961b35fa13d33ee07ef3c346dcf1b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 29 09:33:46 2022 +0200

    Reference the new swh.scrubber module



Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/141/

See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/141/console
Harbormaster failed remote builds in B28035: Diff 27115!Mar 30 2022, 4:30 PM
ardumont added a task: T4120: Fix documentation dev build (again).Mar 30 2022, 4:59 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 30 2022, 6:29 PM
This revision was landed with ongoing or failed builds.
Closed by commit rDDOCf6cbf42ad1d9: Reference the new swh.scrubber module (authored by ardumont).  ·  Explain Why
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDDOCf6cbf42ad1d9: Reference the new swh.scrubber module.
Revision Contents
Changeset List
PathSize
docs/
2 lines
Diff 27095
View Options
docs/index.rst
Loading...
About · Developer information · Legal