Page MenuHomeSoftware Heritage
Differential D7390

django: Ensure defined URLs have trailing slash
ClosedPublic
Actions

Authored by anlambert on Mar 18 2022, 2:51 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDWAPPSdfccbcf9bde1: django: Ensure defined URLs have trailing slash
Summary

URLs targeting a django view must have a trailing slash as
django builtin feature APPEND_SLASH is activated by default.

If an URL definition does not have a trailing slash, this
will result in a 404 error as django will automatically add
a trailing slash if a user forgot to add it and thus the URL
resolving will fail.

Diff Detail

Repository
rDWAPPS Web applications
Branch
urls-trailing-slash
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27616
Build 43223: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 43222: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
4,117 msJenkins > should not send request to the search endpoint::Tests / Cypress tests / Run cypress tests / Test origin-search Test valid SWHIDs should not send request to the search endpoint
AssertionError: expected [ Array(2) ] to have a length of 1 but got 2 at Context.eval (http://localhost:5004/__cypress/tests?p=cypress/support/index.js:119:58)
667 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.add_forge_now.tests.test_migration::Tests / Python tests / test_add_forge_now_initial_migration
293 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.add_forge_now.test_models::Tests / Python tests / test_allowed_next_statuses[RequestStatus.PENDING-allowed_next_statuses0]
175 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.add_forge_now.test_models::Tests / Python tests / test_allowed_next_statuses[RequestStatus.WAITING_FOR_FEEDBACK-allowed_next_statuses1]
865 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.add_forge_now.test_views::Tests / Python tests / test_add_forge_request_list_datatables
View Full Test Results (1 Failed · 919 Passed · 5 Skipped)

Event Timeline

anlambert created this revision.Mar 18 2022, 2:51 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 18 2022, 2:51 PM
swh-public-ci added a comment.Mar 18 2022, 3:07 PM

Build is green

Patch application report for D7390 (id=26693)

Rebasing onto 7bfbda85ff...

Current branch diff-target is up to date.
Changes applied before test
commit c8fbad6d2b5a5166c7faef361a6635bb12751bb0
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Mar 18 14:49:18 2022 +0100

    django: Ensure defined URLs have trailing slash
    
    URLs targeting a django view must have a trailing slash as
    django builtin feature APPEND_SLASH is activated by default.
    
    If an URL definition does not have a trailing slash, this
    will  result in a 404 error as django will automatically add
    a trailing slash if a user forgot to add it and thus the URL
    resolving will fail.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1499/ for more details.

Harbormaster completed remote builds in B27573: Diff 26693.Mar 18 2022, 3:07 PM
anlambert requested review of this revision.Mar 18 2022, 3:07 PM
ardumont accepted this revision.Mar 18 2022, 3:27 PM
This revision is now accepted and ready to land.Mar 18 2022, 3:27 PM
anlambert updated this revision to Diff 26713.Mar 18 2022, 3:52 PM

Rebase and fix some add-forge URLs

swh-public-ci added a comment.Mar 18 2022, 4:20 PM

Build was aborted

Patch application report for D7390 (id=26713)

Rebasing onto 8e11938147...

Current branch diff-target is up to date.
Changes applied before test
commit 10123c72791321525338bde80f648d8a8404360d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Mar 18 14:49:18 2022 +0100

    django: Ensure defined URLs have trailing slash
    
    URLs targeting a django view must have a trailing slash as
    django builtin feature APPEND_SLASH is activated by default.
    
    If an URL definition does not have a trailing slash, this
    will  result in a 404 error as django will automatically add
    a trailing slash if a user forgot to add it and thus the URL
    resolving will fail.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1504/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1504/console

Harbormaster failed remote builds in B27609: Diff 26713!Mar 18 2022, 4:20 PM
ardumont added a comment.Mar 18 2022, 4:43 PM

heads up, i've restarted that build which got aborted.

anlambert updated this revision to Diff 26721.Mar 18 2022, 4:51 PM

Rebase

swh-public-ci added a comment.Mar 18 2022, 5:02 PM

Build is green

Patch application report for D7390 (id=26713)

Rebasing onto f937632950...

First, rewinding head to replay your work on top of it...
Applying: django: Ensure defined URLs have trailing slash
Changes applied before test
commit a7eff3a193ab319e468f27d4a7a135051d4f34af
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Mar 18 14:49:18 2022 +0100

    django: Ensure defined URLs have trailing slash
    
    URLs targeting a django view must have a trailing slash as
    django builtin feature APPEND_SLASH is activated by default.
    
    If an URL definition does not have a trailing slash, this
    will  result in a 404 error as django will automatically add
    a trailing slash if a user forgot to add it and thus the URL
    resolving will fail.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1509/ for more details.

Harbormaster completed remote builds in B27609: Diff 26713.Mar 18 2022, 5:02 PM
anlambert updated this revision to Diff 26723.Mar 18 2022, 5:05 PM

Rerebase

This revision was landed with ongoing or failed builds.Mar 18 2022, 5:07 PM
Closed by commit rDWAPPSdfccbcf9bde1: django: Ensure defined URLs have trailing slash (authored by anlambert). · Explain Why
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPSdfccbcf9bde1: django: Ensure defined URLs have trailing slash.
swh-public-ci added a comment.Mar 18 2022, 5:11 PM

Build has FAILED

Patch application report for D7390 (id=26721)

Rebasing onto f937632950...

Current branch diff-target is up to date.
Changes applied before test
commit 2d4078f3de3c95dbeec47b3019fb107dabd96480
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Mar 18 14:49:18 2022 +0100

    django: Ensure defined URLs have trailing slash
    
    URLs targeting a django view must have a trailing slash as
    django builtin feature APPEND_SLASH is activated by default.
    
    If an URL definition does not have a trailing slash, this
    will  result in a 404 error as django will automatically add
    a trailing slash if a user forgot to add it and thus the URL
    resolving will fail.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1511/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1511/console

Harbormaster failed remote builds in B27616: Diff 26721!Mar 18 2022, 5:11 PM
swh-public-ci added a comment.Mar 18 2022, 5:26 PM

Build is green

Patch application report for D7390 (id=26723)

Rebasing onto 683b349b01...

Current branch diff-target is up to date.
Changes applied before test
commit dfccbcf9bde17caa3dc215f25d81b86d4b94e2ed
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Mar 18 14:49:18 2022 +0100

    django: Ensure defined URLs have trailing slash
    
    URLs targeting a django view must have a trailing slash as
    django builtin feature APPEND_SLASH is activated by default.
    
    If an URL definition does not have a trailing slash, this
    will  result in a 404 error as django will automatically add
    a trailing slash if a user forgot to add it and thus the URL
    resolving will fail.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1512/ for more details.

Harbormaster completed remote builds in B27618: Diff 26723.Mar 18 2022, 5:26 PM

Revision Contents
Changeset List

PathSize
swh/
web/
add_forge_now/
4 lines
api/
views/
6 lines
2 lines
auth/
6 lines
browse/
views/
2 lines
misc/
2 lines
2 lines
2 lines
2 lines
tests/
api/
48 lines
13 lines
4 lines

Diff 26721

View Options

swh/web/add_forge_now/views.py

Loading...
View Options

swh/web/api/views/add_forge_now.py

Loading...
View Options

swh/web/api/views/origin.py

Loading...
View Options

swh/web/auth/mailmap.py

Loading...
View Options

swh/web/browse/views/content.py

Loading...
View Options

swh/web/misc/fundraising.py

Loading...
View Options

swh/web/misc/iframe.py

Loading...
View Options

swh/web/misc/origin_save.py

Loading...
View Options

swh/web/misc/urls.py

Loading...
View Options

swh/web/tests/api/test_throttling.py

Loading...
View Options

swh/web/tests/test_urls.py

Loading...
View Options

swh/web/urls.py

Loading...
About · Developer information · Legal