Page MenuHomeSoftware Heritage

django: Ensure defined URLs have trailing slash
ClosedPublic

Authored by anlambert on Mar 18 2022, 2:51 PM.

Details

Summary

URLs targeting a django view must have a trailing slash as
django builtin feature APPEND_SLASH is activated by default.

If an URL definition does not have a trailing slash, this
will result in a 404 error as django will automatically add
a trailing slash if a user forgot to add it and thus the URL
resolving will fail.

Diff Detail

Repository
rDWAPPS Web applications
Branch
urls-trailing-slash
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27573
Build 43156: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 43155: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D7390 (id=26693)

Rebasing onto 7bfbda85ff...

Current branch diff-target is up to date.
Changes applied before test
commit c8fbad6d2b5a5166c7faef361a6635bb12751bb0
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Mar 18 14:49:18 2022 +0100

    django: Ensure defined URLs have trailing slash
    
    URLs targeting a django view must have a trailing slash as
    django builtin feature APPEND_SLASH is activated by default.
    
    If an URL definition does not have a trailing slash, this
    will  result in a 404 error as django will automatically add
    a trailing slash if a user forgot to add it and thus the URL
    resolving will fail.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1499/ for more details.

This revision is now accepted and ready to land.Mar 18 2022, 3:27 PM

Rebase and fix some add-forge URLs

Build was aborted

Patch application report for D7390 (id=26713)

Rebasing onto 8e11938147...

Current branch diff-target is up to date.
Changes applied before test
commit 10123c72791321525338bde80f648d8a8404360d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Mar 18 14:49:18 2022 +0100

    django: Ensure defined URLs have trailing slash
    
    URLs targeting a django view must have a trailing slash as
    django builtin feature APPEND_SLASH is activated by default.
    
    If an URL definition does not have a trailing slash, this
    will  result in a 404 error as django will automatically add
    a trailing slash if a user forgot to add it and thus the URL
    resolving will fail.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1504/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1504/console

heads up, i've restarted that build which got aborted.

Build is green

Patch application report for D7390 (id=26713)

Rebasing onto f937632950...

First, rewinding head to replay your work on top of it...
Applying: django: Ensure defined URLs have trailing slash
Changes applied before test
commit a7eff3a193ab319e468f27d4a7a135051d4f34af
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Mar 18 14:49:18 2022 +0100

    django: Ensure defined URLs have trailing slash
    
    URLs targeting a django view must have a trailing slash as
    django builtin feature APPEND_SLASH is activated by default.
    
    If an URL definition does not have a trailing slash, this
    will  result in a 404 error as django will automatically add
    a trailing slash if a user forgot to add it and thus the URL
    resolving will fail.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1509/ for more details.

This revision was landed with ongoing or failed builds.Mar 18 2022, 5:07 PM
This revision was automatically updated to reflect the committed changes.

Build has FAILED

Patch application report for D7390 (id=26721)

Rebasing onto f937632950...

Current branch diff-target is up to date.
Changes applied before test
commit 2d4078f3de3c95dbeec47b3019fb107dabd96480
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Mar 18 14:49:18 2022 +0100

    django: Ensure defined URLs have trailing slash
    
    URLs targeting a django view must have a trailing slash as
    django builtin feature APPEND_SLASH is activated by default.
    
    If an URL definition does not have a trailing slash, this
    will  result in a 404 error as django will automatically add
    a trailing slash if a user forgot to add it and thus the URL
    resolving will fail.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1511/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1511/console

Build is green

Patch application report for D7390 (id=26723)

Rebasing onto 683b349b01...

Current branch diff-target is up to date.
Changes applied before test
commit dfccbcf9bde17caa3dc215f25d81b86d4b94e2ed
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Mar 18 14:49:18 2022 +0100

    django: Ensure defined URLs have trailing slash
    
    URLs targeting a django view must have a trailing slash as
    django builtin feature APPEND_SLASH is activated by default.
    
    If an URL definition does not have a trailing slash, this
    will  result in a 404 error as django will automatically add
    a trailing slash if a user forgot to add it and thus the URL
    resolving will fail.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1512/ for more details.