Page MenuHomeSoftware Heritage
Differential D7330

api: Add endpoint to get details about an add-forge request
ClosedPublic
Actions

Authored by anlambert on Mar 10 2022, 2:12 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T4030: Implement "Get request details" API feature
Commits
rDWAPPS26748e56ecce: api: Add endpoint to get details about an add-forge request
Summary

Related to T4030

Depends on D7328

Diff Detail

Repository
rDWAPPS Web applications
Branch
add-forge-request-get
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27410
Build 42890: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 42889: arc lint + arc unit

Event Timeline

anlambert created this revision.Mar 10 2022, 2:12 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 10 2022, 2:12 PM
swh-public-ci added a comment.Mar 10 2022, 2:28 PM

Build is green

Patch application report for D7330 (id=26512)

Could not rebase; Attempt merge onto 51aa6fbc8e...

Merge made by the 'recursive' strategy.
 swh/web/add_forge_now/__init__.py                |   0
 swh/web/add_forge_now/apps.py                    |  10 +
 swh/web/add_forge_now/migrations/0001_initial.py | 109 +++++
 swh/web/add_forge_now/migrations/__init__.py     |   0
 swh/web/add_forge_now/models.py                  |  99 +++++
 swh/web/add_forge_now/tests/test_migration.py    |  62 +++
 swh/web/api/urls.py                              |   1 +
 swh/web/api/views/add_forge_now.py               | 352 ++++++++++++++++
 swh/web/settings/common.py                       |   1 +
 swh/web/tests/add_forge_now/test_models.py       |  26 ++
 swh/web/tests/api/views/test_add_forge_now.py    | 485 +++++++++++++++++++++++
 swh/web/tests/utils.py                           |  10 +-
 12 files changed, 1152 insertions(+), 3 deletions(-)
 create mode 100644 swh/web/add_forge_now/__init__.py
 create mode 100644 swh/web/add_forge_now/apps.py
 create mode 100644 swh/web/add_forge_now/migrations/0001_initial.py
 create mode 100644 swh/web/add_forge_now/migrations/__init__.py
 create mode 100644 swh/web/add_forge_now/models.py
 create mode 100644 swh/web/add_forge_now/tests/test_migration.py
 create mode 100644 swh/web/api/views/add_forge_now.py
 create mode 100644 swh/web/tests/add_forge_now/test_models.py
 create mode 100644 swh/web/tests/api/views/test_add_forge_now.py
Changes applied before test
commit 3269d66da69262e90f7df85c7cb52bfe49098a69
Merge: 51aa6fbc 12a47bc8
Author: Jenkins user <jenkins@localhost>
Date:   Thu Mar 10 13:12:47 2022 +0000

    Merge branch 'diff-target' into HEAD

commit 12a47bc8e97588118dbb020018830cde7792695d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Mar 10 14:09:36 2022 +0100

    api: Add endpoint to get details about an add-forge request
    
    Related to T4030

commit 5677b39669fbd41e52696c54611515a27c31b815
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Mar 9 16:30:06 2022 +0100

    api: Add endpoint to list add-forge requests
    
    Related to T4027

commit 541ac4f8d0dc0bba4ae7c8f268c488776307f17f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Mar 9 16:28:03 2022 +0100

    api: Add endpoint to update an add-forge request
    
    Related to T4026

commit 130e9faa9bcab18bc3c76dc898546edb89f3f9b8
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Mar 8 15:23:50 2022 +0100

    api: Add endpoint to create an add-forge request
    
    Related to T3990

commit 03101208803501e5178f35d18d171e740ee4ca76
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 8 11:34:44 2022 +0100

    add_forge_now: Bootstrap app and model

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1442/ for more details.

Harbormaster completed remote builds in B27397: Diff 26512.Mar 10 2022, 2:28 PM
anlambert requested review of this revision.Mar 10 2022, 2:28 PM
ardumont added 1 blocking reviewer(s): Reviewers.Mar 10 2022, 6:06 PM
ardumont accepted this revision as: ardumont.Mar 10 2022, 6:12 PM
ardumont added subscribers: jayeshv, ardumont.

Great, thx.

fwiw with @jayeshv, we started rebasing our work on top of this top-level diff (so that
includes the other api one) to reuse those apis. It's not complete yet but it's ongoing.

swh/web/api/views/add_forge_now.py
89

what does that change, does that put a lock or something (in between read and create queries)?

vlorentz added a subscriber: vlorentz.Mar 11 2022, 9:54 AM
vlorentz added inline comments.
swh/web/api/views/add_forge_now.py
89

It runs the view in a SQL transaction

anlambert updated this revision to Diff 26526.Mar 11 2022, 10:11 AM

Rebase

swh-public-ci added a comment.Mar 11 2022, 10:14 AM

Build has FAILED

Patch application report for D7330 (id=26526)

Could not rebase; Attempt merge onto cdcc1efdfb...

Merge made by the 'recursive' strategy.
 swh/web/add_forge_now/__init__.py                |   0
 swh/web/add_forge_now/apps.py                    |  10 +
 swh/web/add_forge_now/migrations/0001_initial.py | 109 +++++
 swh/web/add_forge_now/migrations/__init__.py     |   0
 swh/web/add_forge_now/models.py                  |  99 +++++
 swh/web/add_forge_now/tests/test_migration.py    |  62 +++
 swh/web/api/urls.py                              |   1 +
 swh/web/api/views/add_forge_now.py               | 352 ++++++++++++++++
 swh/web/settings/common.py                       |   1 +
 swh/web/tests/add_forge_now/test_models.py       |  26 ++
 swh/web/tests/api/views/test_add_forge_now.py    | 489 +++++++++++++++++++++++
 swh/web/tests/utils.py                           |  10 +-
 12 files changed, 1156 insertions(+), 3 deletions(-)
 create mode 100644 swh/web/add_forge_now/__init__.py
 create mode 100644 swh/web/add_forge_now/apps.py
 create mode 100644 swh/web/add_forge_now/migrations/0001_initial.py
 create mode 100644 swh/web/add_forge_now/migrations/__init__.py
 create mode 100644 swh/web/add_forge_now/models.py
 create mode 100644 swh/web/add_forge_now/tests/test_migration.py
 create mode 100644 swh/web/api/views/add_forge_now.py
 create mode 100644 swh/web/tests/add_forge_now/test_models.py
 create mode 100644 swh/web/tests/api/views/test_add_forge_now.py
Changes applied before test
commit 3b194ff23ae37f766673f40180907c52afb06ee9
Merge: cdcc1efd 26748e56
Author: Jenkins user <jenkins@localhost>
Date:   Fri Mar 11 09:12:31 2022 +0000

    Merge branch 'diff-target' into HEAD

commit 26748e56ecce5877fce3a215eba06a19ebb8342f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Mar 10 14:09:36 2022 +0100

    api: Add endpoint to get details about an add-forge request
    
    Related to T4030

commit 294a95c711bc40622c6d718afa2535f377b90dfc
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Mar 9 16:30:06 2022 +0100

    api: Add endpoint to list add-forge requests
    
    Related to T4027

commit 1bf17d6a75fd7265b1da9c9e87220efa62869c93
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Mar 9 16:28:03 2022 +0100

    api: Add endpoint to update an add-forge request
    
    Related to T4026

commit 130e9faa9bcab18bc3c76dc898546edb89f3f9b8
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Mar 8 15:23:50 2022 +0100

    api: Add endpoint to create an add-forge request
    
    Related to T3990

commit 03101208803501e5178f35d18d171e740ee4ca76
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 8 11:34:44 2022 +0100

    add_forge_now: Bootstrap app and model

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1446/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1446/console

Harbormaster failed remote builds in B27410: Diff 26526!Mar 11 2022, 10:14 AM
swh-public-ci added a comment.Mar 11 2022, 10:44 AM

Build is green

Patch application report for D7330 (id=26526)

Could not rebase; Attempt merge onto cdcc1efdfb...

Merge made by the 'recursive' strategy.
 swh/web/add_forge_now/__init__.py                |   0
 swh/web/add_forge_now/apps.py                    |  10 +
 swh/web/add_forge_now/migrations/0001_initial.py | 109 +++++
 swh/web/add_forge_now/migrations/__init__.py     |   0
 swh/web/add_forge_now/models.py                  |  99 +++++
 swh/web/add_forge_now/tests/test_migration.py    |  62 +++
 swh/web/api/urls.py                              |   1 +
 swh/web/api/views/add_forge_now.py               | 352 ++++++++++++++++
 swh/web/settings/common.py                       |   1 +
 swh/web/tests/add_forge_now/test_models.py       |  26 ++
 swh/web/tests/api/views/test_add_forge_now.py    | 489 +++++++++++++++++++++++
 swh/web/tests/utils.py                           |  10 +-
 12 files changed, 1156 insertions(+), 3 deletions(-)
 create mode 100644 swh/web/add_forge_now/__init__.py
 create mode 100644 swh/web/add_forge_now/apps.py
 create mode 100644 swh/web/add_forge_now/migrations/0001_initial.py
 create mode 100644 swh/web/add_forge_now/migrations/__init__.py
 create mode 100644 swh/web/add_forge_now/models.py
 create mode 100644 swh/web/add_forge_now/tests/test_migration.py
 create mode 100644 swh/web/api/views/add_forge_now.py
 create mode 100644 swh/web/tests/add_forge_now/test_models.py
 create mode 100644 swh/web/tests/api/views/test_add_forge_now.py
Changes applied before test
commit df6d4bd7a96361a730030b5f1920245d76bda698
Merge: cdcc1efd 26748e56
Author: Jenkins user <jenkins@localhost>
Date:   Fri Mar 11 09:29:40 2022 +0000

    Merge branch 'diff-target' into HEAD

commit 26748e56ecce5877fce3a215eba06a19ebb8342f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Mar 10 14:09:36 2022 +0100

    api: Add endpoint to get details about an add-forge request
    
    Related to T4030

commit 294a95c711bc40622c6d718afa2535f377b90dfc
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Mar 9 16:30:06 2022 +0100

    api: Add endpoint to list add-forge requests
    
    Related to T4027

commit 1bf17d6a75fd7265b1da9c9e87220efa62869c93
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Mar 9 16:28:03 2022 +0100

    api: Add endpoint to update an add-forge request
    
    Related to T4026

commit 130e9faa9bcab18bc3c76dc898546edb89f3f9b8
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Mar 8 15:23:50 2022 +0100

    api: Add endpoint to create an add-forge request
    
    Related to T3990

commit 03101208803501e5178f35d18d171e740ee4ca76
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 8 11:34:44 2022 +0100

    add_forge_now: Bootstrap app and model

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1449/ for more details.

Harbormaster completed remote builds in B27410: Diff 26526.Mar 11 2022, 10:45 AM
ardumont accepted this revision.Mar 11 2022, 3:12 PM
This revision is now accepted and ready to land.Mar 11 2022, 3:12 PM
anlambert closed this revision.Mar 11 2022, 4:02 PM

Landed in 26748e56ecce.

anlambert added a commit: rDWAPPS26748e56ecce: api: Add endpoint to get details about an add-forge request.Mar 16 2022, 2:18 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
web/
add_forge_now/
1 line100%
Loading...
api/
views/
64 lines98%
Loading...
tests/
api/
views/
109 lines100%
Loading...

Diff 26526

View Options

swh/web/add_forge_now/models.py

Loading...
View Options

swh/web/api/views/add_forge_now.py

Loading...
View Options

swh/web/tests/api/views/test_add_forge_now.py

Loading...
About · Developer information · Legal