Page MenuHomeSoftware Heritage
Differential D7328

api: Add endpoint to list add-forge requests
ClosedPublic
Actions

Authored by anlambert on Mar 9 2022, 6:07 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T4027: Implement "List requests" API feature
Commits
rDWAPPS294a95c711bc: api: Add endpoint to list add-forge requests
Summary

Related to T4027

Depends on D7327

Diff Detail

Repository
rDWAPPS Web applications
Branch
add-forge-request-list
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27409
Build 42888: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 42887: arc lint + arc unit

Event Timeline

anlambert created this revision.Mar 9 2022, 6:07 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 9 2022, 6:07 PM
swh-public-ci added a comment.Mar 9 2022, 6:25 PM

Build has FAILED

Patch application report for D7328 (id=26501)

Could not rebase; Attempt merge onto 51aa6fbc8e...

Merge made by the 'recursive' strategy.
 swh/web/add_forge_now/__init__.py                |   0
 swh/web/add_forge_now/apps.py                    |  10 +
 swh/web/add_forge_now/migrations/0001_initial.py | 109 ++++++++
 swh/web/add_forge_now/migrations/__init__.py     |   0
 swh/web/add_forge_now/models.py                  | 106 +++++++
 swh/web/add_forge_now/tests/test_migration.py    |  62 +++++
 swh/web/api/urls.py                              |   1 +
 swh/web/api/views/add_forge_now.py               | 275 ++++++++++++++++++
 swh/web/settings/common.py                       |   1 +
 swh/web/tests/add_forge_now/test_models.py       |  35 +++
 swh/web/tests/api/views/test_add_forge_now.py    | 338 +++++++++++++++++++++++
 swh/web/tests/utils.py                           |  10 +-
 12 files changed, 944 insertions(+), 3 deletions(-)
 create mode 100644 swh/web/add_forge_now/__init__.py
 create mode 100644 swh/web/add_forge_now/apps.py
 create mode 100644 swh/web/add_forge_now/migrations/0001_initial.py
 create mode 100644 swh/web/add_forge_now/migrations/__init__.py
 create mode 100644 swh/web/add_forge_now/models.py
 create mode 100644 swh/web/add_forge_now/tests/test_migration.py
 create mode 100644 swh/web/api/views/add_forge_now.py
 create mode 100644 swh/web/tests/add_forge_now/test_models.py
 create mode 100644 swh/web/tests/api/views/test_add_forge_now.py
Changes applied before test
commit 3d2c567f70eac62c514c6a67a6419d7445ffddb7
Merge: 51aa6fbc 76498235
Author: Jenkins user <jenkins@localhost>
Date:   Wed Mar 9 17:08:35 2022 +0000

    Merge branch 'diff-target' into HEAD

commit 764982358037498c28d2f26ac49bef1a9a81a5bc
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Mar 9 16:30:06 2022 +0100

    api: Add endpoint to list add-forge requests
    
    Related to T4027

commit 5233e3c34c67445b04182a93dd9f334233922601
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Mar 9 16:28:03 2022 +0100

    api: Add endpoint to update an add-forge request
    
    Related to T4026

commit 130e9faa9bcab18bc3c76dc898546edb89f3f9b8
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Mar 8 15:23:50 2022 +0100

    api: Add endpoint to create an add-forge request
    
    Related to T3990

commit 03101208803501e5178f35d18d171e740ee4ca76
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 8 11:34:44 2022 +0100

    add_forge_now: Bootstrap app and model

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1436/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1436/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 9 2022, 6:25 PM
Harbormaster failed remote builds in B27386: Diff 26501!
anlambert updated this revision to Diff 26508.Mar 10 2022, 11:52 AM

Rebase and fix test

swh-public-ci added a comment.Mar 10 2022, 12:10 PM

Build has FAILED

Patch application report for D7328 (id=26508)

Could not rebase; Attempt merge onto 51aa6fbc8e...

Merge made by the 'recursive' strategy.
 swh/web/add_forge_now/__init__.py                |   0
 swh/web/add_forge_now/apps.py                    |  10 +
 swh/web/add_forge_now/migrations/0001_initial.py | 109 +++++++
 swh/web/add_forge_now/migrations/__init__.py     |   0
 swh/web/add_forge_now/models.py                  |  98 ++++++
 swh/web/add_forge_now/tests/test_migration.py    |  62 ++++
 swh/web/api/urls.py                              |   1 +
 swh/web/api/views/add_forge_now.py               | 285 +++++++++++++++++
 swh/web/settings/common.py                       |   1 +
 swh/web/tests/add_forge_now/test_models.py       |  26 ++
 swh/web/tests/api/views/test_add_forge_now.py    | 382 +++++++++++++++++++++++
 swh/web/tests/utils.py                           |  10 +-
 12 files changed, 981 insertions(+), 3 deletions(-)
 create mode 100644 swh/web/add_forge_now/__init__.py
 create mode 100644 swh/web/add_forge_now/apps.py
 create mode 100644 swh/web/add_forge_now/migrations/0001_initial.py
 create mode 100644 swh/web/add_forge_now/migrations/__init__.py
 create mode 100644 swh/web/add_forge_now/models.py
 create mode 100644 swh/web/add_forge_now/tests/test_migration.py
 create mode 100644 swh/web/api/views/add_forge_now.py
 create mode 100644 swh/web/tests/add_forge_now/test_models.py
 create mode 100644 swh/web/tests/api/views/test_add_forge_now.py
Changes applied before test
commit bcf071c17eeb2711c7a6a08a3aef6fffa149b293
Merge: 51aa6fbc 9d4c69c9
Author: Jenkins user <jenkins@localhost>
Date:   Thu Mar 10 10:53:05 2022 +0000

    Merge branch 'diff-target' into HEAD

commit 9d4c69c93c17b8a488ceb666ec0eaa7198841f68
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Mar 9 16:30:06 2022 +0100

    api: Add endpoint to list add-forge requests
    
    Related to T4027

commit b10097c0457e957bb64ef70e2ea4640112db98cb
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Mar 9 16:28:03 2022 +0100

    api: Add endpoint to update an add-forge request
    
    Related to T4026

commit 130e9faa9bcab18bc3c76dc898546edb89f3f9b8
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Mar 8 15:23:50 2022 +0100

    api: Add endpoint to create an add-forge request
    
    Related to T3990

commit 03101208803501e5178f35d18d171e740ee4ca76
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 8 11:34:44 2022 +0100

    add_forge_now: Bootstrap app and model

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1438/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1438/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 10 2022, 12:10 PM
Harbormaster failed remote builds in B27393: Diff 26508!
anlambert updated this revision to Diff 26510.Mar 10 2022, 1:23 PM

Rebase

anlambert updated this revision to Diff 26511.Mar 10 2022, 1:27 PM

Fix docstring

swh-public-ci added a comment.Mar 10 2022, 1:43 PM

Build is green

Patch application report for D7328 (id=26510)

Could not rebase; Attempt merge onto 51aa6fbc8e...

Merge made by the 'recursive' strategy.
 swh/web/add_forge_now/__init__.py                |   0
 swh/web/add_forge_now/apps.py                    |  10 +
 swh/web/add_forge_now/migrations/0001_initial.py | 109 +++++++
 swh/web/add_forge_now/migrations/__init__.py     |   0
 swh/web/add_forge_now/models.py                  |  98 ++++++
 swh/web/add_forge_now/tests/test_migration.py    |  62 ++++
 swh/web/api/urls.py                              |   1 +
 swh/web/api/views/add_forge_now.py               | 289 +++++++++++++++++
 swh/web/settings/common.py                       |   1 +
 swh/web/tests/add_forge_now/test_models.py       |  26 ++
 swh/web/tests/api/views/test_add_forge_now.py    | 382 +++++++++++++++++++++++
 swh/web/tests/utils.py                           |  10 +-
 12 files changed, 985 insertions(+), 3 deletions(-)
 create mode 100644 swh/web/add_forge_now/__init__.py
 create mode 100644 swh/web/add_forge_now/apps.py
 create mode 100644 swh/web/add_forge_now/migrations/0001_initial.py
 create mode 100644 swh/web/add_forge_now/migrations/__init__.py
 create mode 100644 swh/web/add_forge_now/models.py
 create mode 100644 swh/web/add_forge_now/tests/test_migration.py
 create mode 100644 swh/web/api/views/add_forge_now.py
 create mode 100644 swh/web/tests/add_forge_now/test_models.py
 create mode 100644 swh/web/tests/api/views/test_add_forge_now.py
Changes applied before test
commit 75ef7ba8a468ae32b6c3a9600f75f8ee5ba126c3
Merge: 51aa6fbc ba1aa954
Author: Jenkins user <jenkins@localhost>
Date:   Thu Mar 10 12:24:22 2022 +0000

    Merge branch 'diff-target' into HEAD

commit ba1aa95498e9cef5a51ae8b7f196818d01ad84aa
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Mar 9 16:30:06 2022 +0100

    api: Add endpoint to list add-forge requests
    
    Related to T4027

commit 541ac4f8d0dc0bba4ae7c8f268c488776307f17f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Mar 9 16:28:03 2022 +0100

    api: Add endpoint to update an add-forge request
    
    Related to T4026

commit 130e9faa9bcab18bc3c76dc898546edb89f3f9b8
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Mar 8 15:23:50 2022 +0100

    api: Add endpoint to create an add-forge request
    
    Related to T3990

commit 03101208803501e5178f35d18d171e740ee4ca76
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 8 11:34:44 2022 +0100

    add_forge_now: Bootstrap app and model

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1440/ for more details.

Harbormaster completed remote builds in B27395: Diff 26510.Mar 10 2022, 1:43 PM
swh-public-ci added a comment.Mar 10 2022, 1:44 PM

Build is green

Patch application report for D7328 (id=26511)

Could not rebase; Attempt merge onto 51aa6fbc8e...

Merge made by the 'recursive' strategy.
 swh/web/add_forge_now/__init__.py                |   0
 swh/web/add_forge_now/apps.py                    |  10 +
 swh/web/add_forge_now/migrations/0001_initial.py | 109 +++++++
 swh/web/add_forge_now/migrations/__init__.py     |   0
 swh/web/add_forge_now/models.py                  |  98 ++++++
 swh/web/add_forge_now/tests/test_migration.py    |  62 ++++
 swh/web/api/urls.py                              |   1 +
 swh/web/api/views/add_forge_now.py               | 289 +++++++++++++++++
 swh/web/settings/common.py                       |   1 +
 swh/web/tests/add_forge_now/test_models.py       |  26 ++
 swh/web/tests/api/views/test_add_forge_now.py    | 382 +++++++++++++++++++++++
 swh/web/tests/utils.py                           |  10 +-
 12 files changed, 985 insertions(+), 3 deletions(-)
 create mode 100644 swh/web/add_forge_now/__init__.py
 create mode 100644 swh/web/add_forge_now/apps.py
 create mode 100644 swh/web/add_forge_now/migrations/0001_initial.py
 create mode 100644 swh/web/add_forge_now/migrations/__init__.py
 create mode 100644 swh/web/add_forge_now/models.py
 create mode 100644 swh/web/add_forge_now/tests/test_migration.py
 create mode 100644 swh/web/api/views/add_forge_now.py
 create mode 100644 swh/web/tests/add_forge_now/test_models.py
 create mode 100644 swh/web/tests/api/views/test_add_forge_now.py
Changes applied before test
commit e3138079a65245da20ce6bafe95398caecc5387c
Merge: 51aa6fbc 5677b396
Author: Jenkins user <jenkins@localhost>
Date:   Thu Mar 10 12:28:14 2022 +0000

    Merge branch 'diff-target' into HEAD

commit 5677b39669fbd41e52696c54611515a27c31b815
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Mar 9 16:30:06 2022 +0100

    api: Add endpoint to list add-forge requests
    
    Related to T4027

commit 541ac4f8d0dc0bba4ae7c8f268c488776307f17f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Mar 9 16:28:03 2022 +0100

    api: Add endpoint to update an add-forge request
    
    Related to T4026

commit 130e9faa9bcab18bc3c76dc898546edb89f3f9b8
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Mar 8 15:23:50 2022 +0100

    api: Add endpoint to create an add-forge request
    
    Related to T3990

commit 03101208803501e5178f35d18d171e740ee4ca76
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 8 11:34:44 2022 +0100

    add_forge_now: Bootstrap app and model

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1441/ for more details.

Harbormaster completed remote builds in B27396: Diff 26511.Mar 10 2022, 1:44 PM
anlambert requested review of this revision.Mar 10 2022, 1:44 PM
anlambert added a child revision: D7330: api: Add endpoint to get details about an add-forge request.Mar 10 2022, 2:12 PM
ardumont accepted this revision as: ardumont.Mar 10 2022, 6:12 PM
ardumont added 1 blocking reviewer(s): Reviewers.
ardumont added a subscriber: ardumont.

lgtm

fast review since i did early today and forgot to tell as much.

anlambert updated this revision to Diff 26525.Mar 11 2022, 10:10 AM

Rebase

swh-public-ci added a comment.Mar 11 2022, 10:28 AM

Build is green

Patch application report for D7328 (id=26525)

Could not rebase; Attempt merge onto cdcc1efdfb...

Merge made by the 'recursive' strategy.
 swh/web/add_forge_now/__init__.py                |   0
 swh/web/add_forge_now/apps.py                    |  10 +
 swh/web/add_forge_now/migrations/0001_initial.py | 109 +++++++
 swh/web/add_forge_now/migrations/__init__.py     |   0
 swh/web/add_forge_now/models.py                  |  98 ++++++
 swh/web/add_forge_now/tests/test_migration.py    |  62 ++++
 swh/web/api/urls.py                              |   1 +
 swh/web/api/views/add_forge_now.py               | 290 +++++++++++++++++
 swh/web/settings/common.py                       |   1 +
 swh/web/tests/add_forge_now/test_models.py       |  26 ++
 swh/web/tests/api/views/test_add_forge_now.py    | 386 +++++++++++++++++++++++
 swh/web/tests/utils.py                           |  10 +-
 12 files changed, 990 insertions(+), 3 deletions(-)
 create mode 100644 swh/web/add_forge_now/__init__.py
 create mode 100644 swh/web/add_forge_now/apps.py
 create mode 100644 swh/web/add_forge_now/migrations/0001_initial.py
 create mode 100644 swh/web/add_forge_now/migrations/__init__.py
 create mode 100644 swh/web/add_forge_now/models.py
 create mode 100644 swh/web/add_forge_now/tests/test_migration.py
 create mode 100644 swh/web/api/views/add_forge_now.py
 create mode 100644 swh/web/tests/add_forge_now/test_models.py
 create mode 100644 swh/web/tests/api/views/test_add_forge_now.py
Changes applied before test
commit 87931587c291041b356982ec740570949f6f9fe7
Merge: cdcc1efd 294a95c7
Author: Jenkins user <jenkins@localhost>
Date:   Fri Mar 11 09:11:31 2022 +0000

    Merge branch 'diff-target' into HEAD

commit 294a95c711bc40622c6d718afa2535f377b90dfc
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Mar 9 16:30:06 2022 +0100

    api: Add endpoint to list add-forge requests
    
    Related to T4027

commit 1bf17d6a75fd7265b1da9c9e87220efa62869c93
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Mar 9 16:28:03 2022 +0100

    api: Add endpoint to update an add-forge request
    
    Related to T4026

commit 130e9faa9bcab18bc3c76dc898546edb89f3f9b8
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Mar 8 15:23:50 2022 +0100

    api: Add endpoint to create an add-forge request
    
    Related to T3990

commit 03101208803501e5178f35d18d171e740ee4ca76
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 8 11:34:44 2022 +0100

    add_forge_now: Bootstrap app and model

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1445/ for more details.

Harbormaster completed remote builds in B27409: Diff 26525.Mar 11 2022, 10:28 AM
ardumont accepted this revision.Mar 11 2022, 3:11 PM
This revision is now accepted and ready to land.Mar 11 2022, 3:11 PM
anlambert closed this revision.Mar 11 2022, 4:02 PM

Landed in 294a95c711bc.

anlambert added a commit: rDWAPPS294a95c711bc: api: Add endpoint to list add-forge requests.Mar 16 2022, 2:18 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
web/
api/
views/
64 lines98%
Loading...
tests/
api/
views/
119 lines100%
Loading...

Diff 26525

View Options

swh/web/api/views/add_forge_now.py

Loading...
View Options

swh/web/tests/api/views/test_add_forge_now.py

Loading...
About · Developer information · Legal