Page MenuHomeSoftware Heritage
Differential D7321

WIP: Create Submission form w/basic info
AbandonedPublic
Actions

Authored by jayeshv on Mar 8 2022, 6:04 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Maniphest Tasks
T3989: [Add forge now] Create "browse add requests" tab
T3987: [Add forge now] Create Submission form w/basic info
Summary

Created template, posting to API, Message
TODO:

  • Tests (when, with the sprint team, we'll settle on the actual implementation)
  • CSS

Related to T3987
Depends on D7311

Diff Detail

Repository
rDWAPPS Web applications
Branch
request-submit
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27351
Build 42787: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 42786: arc lint + arc unit

Event Timeline

jayeshv created this revision.Mar 8 2022, 6:04 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 8 2022, 6:04 PM
swh-public-ci added a comment.Mar 8 2022, 6:24 PM

Build is green

Patch application report for D7321 (id=26466)

Could not rebase; Attempt merge onto 7e5b06ff77...

Merge made by the 'recursive' strategy.
 swh/web/add_forge_now/__init__.py                  |   0
 swh/web/add_forge_now/apps.py                      |   5 +
 swh/web/add_forge_now/migrations/0001_initial.py   | 109 +++++++++++++++++++++
 swh/web/add_forge_now/migrations/__init__.py       |   0
 swh/web/add_forge_now/models.py                    |  71 ++++++++++++++
 swh/web/add_forge_now/urls.py                      |   7 ++
 swh/web/add_forge_now/views.py                     |  24 +++++
 swh/web/api/urls.py                                |   1 +
 swh/web/api/views/add_forge_now.py                 |  95 ++++++++++++++++++
 swh/web/settings/common.py                         |   1 +
 .../templates/add_forge_now/submit-request.html    |  82 ++++++++++++++++
 swh/web/templates/layout.html                      |   6 ++
 swh/web/tests/api/views/test_add_forge_now.py      | 100 +++++++++++++++++++
 swh/web/tests/utils.py                             |   4 +-
 swh/web/urls.py                                    |   1 +
 15 files changed, 505 insertions(+), 1 deletion(-)
 create mode 100644 swh/web/add_forge_now/__init__.py
 create mode 100644 swh/web/add_forge_now/apps.py
 create mode 100644 swh/web/add_forge_now/migrations/0001_initial.py
 create mode 100644 swh/web/add_forge_now/migrations/__init__.py
 create mode 100644 swh/web/add_forge_now/models.py
 create mode 100644 swh/web/add_forge_now/urls.py
 create mode 100644 swh/web/add_forge_now/views.py
 create mode 100644 swh/web/api/views/add_forge_now.py
 create mode 100644 swh/web/templates/add_forge_now/submit-request.html
 create mode 100644 swh/web/tests/api/views/test_add_forge_now.py
Changes applied before test
commit 3b8eccf33154772b373315da666bb096f1a13518
Merge: 7e5b06ff 83951cb2
Author: Jenkins user <jenkins@localhost>
Date:   Tue Mar 8 17:05:32 2022 +0000

    Merge branch 'diff-target' into HEAD

commit 83951cb27427d59a41c9380d8bac5cec22e678dc
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Mar 8 15:14:21 2022 +0100

    Create Submission form w/basic info
    
    Created template, posting to API, Messages
    Related to T3987
    Depends on D7311

commit b93e23c1f378239564fd940bab409ee1e7a3910c
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Mar 8 15:23:50 2022 +0100

    api: Add endpoint to create an add-forge request
    
    Related to T3990

commit c5c3a06143dafb42a986540f25c0d333b49a7a1a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 8 13:20:34 2022 +0100

    add_forge_now: Bootstrap app and model
    
    Summary: Related to T4019
    
    Test Plan: tox happy]
    
    Reviewers: #reviewers
    
    Maniphest Tasks: T4019
    
    Differential Revision: https://forge.softwareheritage.org/D7309

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1423/ for more details.

Harbormaster completed remote builds in B27351: Diff 26466.Mar 8 2022, 6:24 PM
jayeshv requested review of this revision.Mar 8 2022, 6:24 PM
vlorentz added a subscriber: vlorentz.Mar 8 2022, 8:11 PM

Some early comments below

Please add/update copyright headers

swh/web/templates/add_forge_now/submit-request.html
24

You should use {% url %}, and change the id to be less likely to collide with future forms

63–80

Shouldn't this be with the rest of the JS code?

And if not, it probably needs a license to pass LibreJS.

swh/web/urls.py
65

to be consistent with the API endpoint

jayeshv updated this revision to Diff 26478.Mar 8 2022, 9:23 PM

Basic template styling

swh-public-ci added a comment.Mar 8 2022, 9:25 PM

Build has FAILED

Patch application report for D7321 (id=26478)

Could not rebase; Attempt merge onto 7e5b06ff77...

Merge made by the 'recursive' strategy.
 swh/web/add_forge_now/__init__.py                  |   0
 swh/web/add_forge_now/apps.py                      |   5 +
 swh/web/add_forge_now/migrations/0001_initial.py   | 109 ++++++++++++++++++
 swh/web/add_forge_now/migrations/__init__.py       |   0
 swh/web/add_forge_now/models.py                    |  71 ++++++++++++
 swh/web/add_forge_now/urls.py                      |   7 ++
 swh/web/add_forge_now/views.py                     |  34 ++++++
 swh/web/api/urls.py                                |   1 +
 swh/web/api/views/add_forge_now.py                 |  95 +++++++++++++++
 swh/web/settings/common.py                         |   1 +
 .../templates/add_forge_now/submit-request.html    | 128 +++++++++++++++++++++
 swh/web/templates/layout.html                      |   6 +
 swh/web/tests/api/views/test_add_forge_now.py      | 100 ++++++++++++++++
 swh/web/tests/utils.py                             |   4 +-
 swh/web/urls.py                                    |   1 +
 15 files changed, 561 insertions(+), 1 deletion(-)
 create mode 100644 swh/web/add_forge_now/__init__.py
 create mode 100644 swh/web/add_forge_now/apps.py
 create mode 100644 swh/web/add_forge_now/migrations/0001_initial.py
 create mode 100644 swh/web/add_forge_now/migrations/__init__.py
 create mode 100644 swh/web/add_forge_now/models.py
 create mode 100644 swh/web/add_forge_now/urls.py
 create mode 100644 swh/web/add_forge_now/views.py
 create mode 100644 swh/web/api/views/add_forge_now.py
 create mode 100644 swh/web/templates/add_forge_now/submit-request.html
 create mode 100644 swh/web/tests/api/views/test_add_forge_now.py
Changes applied before test
commit 7a42602a60316a0db7419b3cf7e799b9bcdb8d31
Merge: 7e5b06ff a151a644
Author: Jenkins user <jenkins@localhost>
Date:   Tue Mar 8 20:24:04 2022 +0000

    Merge branch 'diff-target' into HEAD

commit a151a644f608df987374c9d79bf898358bc79df9
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Mar 8 21:19:58 2022 +0100

    Basic template styling
    
    Added existing requests table

commit 83951cb27427d59a41c9380d8bac5cec22e678dc
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Mar 8 15:14:21 2022 +0100

    Create Submission form w/basic info
    
    Created template, posting to API, Messages
    Related to T3987
    Depends on D7311

commit b93e23c1f378239564fd940bab409ee1e7a3910c
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Mar 8 15:23:50 2022 +0100

    api: Add endpoint to create an add-forge request
    
    Related to T3990

commit c5c3a06143dafb42a986540f25c0d333b49a7a1a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 8 13:20:34 2022 +0100

    add_forge_now: Bootstrap app and model
    
    Summary: Related to T4019
    
    Test Plan: tox happy]
    
    Reviewers: #reviewers
    
    Maniphest Tasks: T4019
    
    Differential Revision: https://forge.softwareheritage.org/D7309

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1424/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1424/console

Harbormaster failed remote builds in B27363: Diff 26478!Mar 8 2022, 9:25 PM
anlambert added a subscriber: anlambert.Mar 9 2022, 10:48 AM
anlambert added inline comments.
swh/web/templates/add_forge_now/submit-request.html
108–125

You should put this code in a dedicated js file (for instance in the save webpack bundle by adding a new assets/src/bundles/save/add-forge.js file) and wrap it in a function.

There will likely other javascript code to write so better centralizing it in a single place.

anlambert added inline comments.Mar 9 2022, 10:50 AM
swh/web/templates/add_forge_now/submit-request.html
4

2022

63–80

And if not, it probably needs a license to pass LibreJS.

No need, it is already handled in the root layout.html file.

ardumont added a subscriber: ardumont.Mar 9 2022, 12:21 PM

Please add/update copyright headers

yes, that's something that will be done.

swh/web/urls.py
65

which is actually inconsistent with the save api (i forgot to mention in @anlambert's diff)...

jayeshv updated this revision to Diff 26485.Mar 9 2022, 2:54 PM

Add request browsing
Style improvements
Copyright info
Rebase on the latest sprint team work

ardumont added a task: T3989: [Add forge now] Create "browse add requests" tab.Mar 9 2022, 3:00 PM
swh-public-ci added a comment.Mar 9 2022, 3:10 PM

Build is green

Patch application report for D7321 (id=26485)

Could not rebase; Attempt merge onto 7e5b06ff77...

Updating 7e5b06ff..d621545a
Fast-forward
 assets/src/bundles/add_forge/index.js              |  29 +++++
 swh/web/add_forge_now/__init__.py                  |   0
 swh/web/add_forge_now/apps.py                      |  10 ++
 swh/web/add_forge_now/migrations/0001_initial.py   | 109 ++++++++++++++++++
 swh/web/add_forge_now/migrations/__init__.py       |   0
 swh/web/add_forge_now/models.py                    |  71 ++++++++++++
 swh/web/add_forge_now/tests/test_migration.py      |  62 +++++++++++
 swh/web/add_forge_now/urls.py                      |   7 ++
 swh/web/add_forge_now/views.py                     |  39 +++++++
 swh/web/api/urls.py                                |   1 +
 swh/web/api/views/add_forge_now.py                 | 108 ++++++++++++++++++
 swh/web/settings/common.py                         |   1 +
 .../templates/add_forge_now/create-request.html    | 123 +++++++++++++++++++++
 swh/web/templates/layout.html                      |   6 +
 swh/web/tests/api/views/test_add_forge_now.py      | 117 ++++++++++++++++++++
 swh/web/tests/utils.py                             |   4 +-
 swh/web/urls.py                                    |   1 +
 17 files changed, 687 insertions(+), 1 deletion(-)
 create mode 100644 assets/src/bundles/add_forge/index.js
 create mode 100644 swh/web/add_forge_now/__init__.py
 create mode 100644 swh/web/add_forge_now/apps.py
 create mode 100644 swh/web/add_forge_now/migrations/0001_initial.py
 create mode 100644 swh/web/add_forge_now/migrations/__init__.py
 create mode 100644 swh/web/add_forge_now/models.py
 create mode 100644 swh/web/add_forge_now/tests/test_migration.py
 create mode 100644 swh/web/add_forge_now/urls.py
 create mode 100644 swh/web/add_forge_now/views.py
 create mode 100644 swh/web/api/views/add_forge_now.py
 create mode 100644 swh/web/templates/add_forge_now/create-request.html
 create mode 100644 swh/web/tests/api/views/test_add_forge_now.py
Changes applied before test
commit d621545abe1d11f53d78b5e81788b9497f35d8a6
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Mar 8 21:19:58 2022 +0100

    Add browse existing requests table view
    
    Add different screens for anonymous and logged in user
    Improve template style
    
    Related to T3987

commit 1b7b4058051f632797a29dbe88b55cb37b07f3e0
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Mar 8 15:14:21 2022 +0100

    Create Submission form w/basic info
    
    Created template, posting to API, Messages
    Related to T3987
    Depends on D7311

commit 130e9faa9bcab18bc3c76dc898546edb89f3f9b8
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Mar 8 15:23:50 2022 +0100

    api: Add endpoint to create an add-forge request
    
    Related to T3990

commit 03101208803501e5178f35d18d171e740ee4ca76
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 8 11:34:44 2022 +0100

    add_forge_now: Bootstrap app and model

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1429/ for more details.

Harbormaster completed remote builds in B27370: Diff 26485.Mar 9 2022, 3:10 PM
ardumont edited the summary of this revision. (Show Details)Mar 9 2022, 5:21 PM
olasd added a subscriber: olasd.Mar 10 2022, 11:02 AM
olasd added inline comments.
swh/web/add_forge_now/views.py
21–29

We'll probably want to bikeshed these form attributes (field lengths) before landing them :-)

vlorentz added inline comments.Mar 10 2022, 2:04 PM
swh/web/templates/add_forge_now/create-request.html
104 ↗(On Diff #26485)

please use more explicit names for both variables

jayeshv abandoned this revision.Mar 16 2022, 10:32 AM

Implementation has changed a lot; So abandoning this revision in favor of D7357
Comments here will be incorporated in D7357

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
web/
add_forge_now/
7 lines100%
Loading...
24 lines83%
Loading...
templates/
add_forge_now/
82 lines--
6 lines--
1 line88%
Loading...

Diff 26466

View Options

swh/web/add_forge_now/urls.py

Loading...
View Options

swh/web/add_forge_now/views.py

Loading...
View Options

swh/web/templates/add_forge_now/submit-request.html

Loading...
View Options

swh/web/templates/layout.html

Loading...
View Options

swh/web/urls.py

Loading...
About · Developer information · Legal