Differential D6773

journalprocessor: Reuse the Kafka key instead of computing a new one
ClosedPublic
Actions

Authored by vlorentz on Dec 7 2021, 2:54 PM.

Details

Reviewers

seirl

Group Reviewers

Reviewers

Commits

rDDATASETab2ebfadcf29: journalprocessor: Reuse the Kafka key instead of computing a new one

Test Plan

Not tested because I'm lazy. I don't mind waiting for you to write tests before landing

Diff Detail

Repository

rDDATASET Datasets

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 7 2021, 2:54 PM

Build is green

Patch application report for D6773 (id=24572)

Rebasing onto 7b883f16ae...

Current branch diff-target is up to date.

Changes applied before test

commit 77fec7a233fedeea574acd5b1ea9ab616e94565b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Dec 7 14:53:48 2021 +0100

    journalprocessor: Reuse the Kafka key instead of computing a new one

See https://jenkins.softwareheritage.org/job/DDATASET/job/tests-on-diff/19/ for more details.

Harbormaster completed remote builds in B25444: Diff 24572.Dec 7 2021, 2:57 PM

vlorentz requested review of this revision.Dec 7 2021, 2:57 PM

olasd added a subscriber: olasd.Dec 8 2021, 2:35 PM

olasd added inline comments.

swh/dataset/journalprocessor.py
397–399	this loop definitely needs an update

oops, indeed

vlorentz marked an inline comment as done.Dec 8 2021, 2:39 PM

Build is green

Patch application report for D6773 (id=24625)

Rebasing onto 7b883f16ae...

Current branch diff-target is up to date.

Changes applied before test

commit 6c5312fbc0aeca80df721c425ae97919752da685
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Dec 7 14:53:48 2021 +0100

    journalprocessor: Reuse the Kafka key instead of computing a new one

See https://jenkins.softwareheritage.org/job/DDATASET/job/tests-on-diff/20/ for more details.

Harbormaster completed remote builds in B25484: Diff 24625.Dec 8 2021, 2:41 PM

seirl accepted this revision.Jan 20 2022, 4:32 PM

This revision is now accepted and ready to land.Jan 20 2022, 4:32 PM

rebase

Build is green

Patch application report for D6773 (id=25351)

Rebasing onto 8d9fcb8edf...

Current branch diff-target is up to date.

Changes applied before test

commit ab2ebfadcf29800053d65f54fe367492aa5e96aa
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Dec 7 14:53:48 2021 +0100

    journalprocessor: Reuse the Kafka key instead of computing a new one

See https://jenkins.softwareheritage.org/job/DDATASET/job/tests-on-diff/21/ for more details.

Harbormaster completed remote builds in B26197: Diff 25351.Jan 20 2022, 4:38 PM

Closed by commit rDDATASETab2ebfadcf29: journalprocessor: Reuse the Kafka key instead of computing a new one (authored by vlorentz). · Explain WhyJan 20 2022, 4:49 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDDATASETab2ebfadcf29: journalprocessor: Reuse the Kafka key instead of computing a new one.