Page MenuHomeSoftware Heritage

journalprocessor: Reuse the Kafka key instead of computing a new one
ClosedPublic

Authored by vlorentz on Dec 7 2021, 2:54 PM.

Details

Test Plan

Not tested because I'm lazy. I don't mind waiting for you to write tests before landing

Diff Detail

Repository
rDDATASET Datasets
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26197
Build 40951: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 40950: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D6773 (id=24572)

Rebasing onto 7b883f16ae...

Current branch diff-target is up to date.
Changes applied before test
commit 77fec7a233fedeea574acd5b1ea9ab616e94565b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Dec 7 14:53:48 2021 +0100

    journalprocessor: Reuse the Kafka key instead of computing a new one

See https://jenkins.softwareheritage.org/job/DDATASET/job/tests-on-diff/19/ for more details.

olasd added inline comments.
swh/dataset/journalprocessor.py
397–399

this loop definitely needs an update

Build is green

Patch application report for D6773 (id=24625)

Rebasing onto 7b883f16ae...

Current branch diff-target is up to date.
Changes applied before test
commit 6c5312fbc0aeca80df721c425ae97919752da685
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Dec 7 14:53:48 2021 +0100

    journalprocessor: Reuse the Kafka key instead of computing a new one

See https://jenkins.softwareheritage.org/job/DDATASET/job/tests-on-diff/20/ for more details.

This revision is now accepted and ready to land.Jan 20 2022, 4:32 PM

Build is green

Patch application report for D6773 (id=25351)

Rebasing onto 8d9fcb8edf...

Current branch diff-target is up to date.
Changes applied before test
commit ab2ebfadcf29800053d65f54fe367492aa5e96aa
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Dec 7 14:53:48 2021 +0100

    journalprocessor: Reuse the Kafka key instead of computing a new one

See https://jenkins.softwareheritage.org/job/DDATASET/job/tests-on-diff/21/ for more details.