Page MenuHomeSoftware Heritage

postgres: Add indices to keep track of objects with a raw_manifest
ClosedPublic

Authored by vlorentz on Jan 17 2022, 4:59 PM.

Details

Summary

They should be a rare occurence, so adding these indices allows us to count
and enumerate them without expensive full table scans.

Diff Detail

Repository
rDSTO Storage manager
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26074
Build 40749: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 40748: arc lint + arc unit

Event Timeline

Build has FAILED

Patch application report for D6958 (id=25213)

Rebasing onto 40a57d4351...

Current branch diff-target is up to date.
Changes applied before test
commit 8d5055eac54771d65e887455fe7ab2a66b96a445
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jan 17 16:59:37 2022 +0100

    postgres: Add indices to keep track of objects with a raw_manifest
    
    They should be a rare occurence, so adding these indices allows us to count
    and enumerate them without expensive full table scans.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1527/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1527/console

Build has FAILED

Patch application report for D6958 (id=25214)

Rebasing onto 40a57d4351...

Current branch diff-target is up to date.
Changes applied before test
commit 25ad2a490e46bab4f9d534befe49c296bac18599
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jan 17 16:59:37 2022 +0100

    postgres: Add indices to keep track of objects with a raw_manifest
    
    They should be a rare occurence, so adding these indices allows us to count
    and enumerate them without expensive full table scans.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1528/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1528/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 17 2022, 5:22 PM
Harbormaster failed remote builds in B26075: Diff 25214!
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 18 2022, 10:26 AM
Harbormaster failed remote builds in B26081: Diff 25220!

Build is green

Patch application report for D6958 (id=25220)

Rebasing onto 228de33736...

Current branch diff-target is up to date.
Changes applied before test
commit 34ddbd3ccd748fb199a2a4d26bb114114001d9c6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jan 17 16:59:37 2022 +0100

    postgres: Add indices to keep track of objects with a raw_manifest
    
    They should be a rare occurence, so adding these indices allows us to count
    and enumerate them without expensive full table scans.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1531/ for more details.

Sounds good. I don't think we need to make them unique though (and it might make stuff confusing if writes get rejected by this index rather than the primary one)

Build is green

Patch application report for D6958 (id=25236)

Rebasing onto 228de33736...

Current branch diff-target is up to date.
Changes applied before test
commit c68a4fd98fb4025b67b093053d96d23a7a6937cb
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jan 17 16:59:37 2022 +0100

    postgres: Add indices to keep track of objects with a raw_manifest
    
    They should be a rare occurence, so adding these indices allows us to count
    and enumerate them without expensive full table scans.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1532/ for more details.

This revision is now accepted and ready to land.Jan 18 2022, 11:35 AM