Test for the subversion loader now use the in-memory storage.
Also use new test method names from swh-loader-core.
Related T1421
Details
Details
- Reviewers
ardumont vlorentz - Group Reviewers
Reviewers - Maniphest Tasks
- T1307: Remove mock storages used in tests.
- Commits
- rDLDSVN6f65e78f025b: tests: Refactor, use in-memory storage and reflect changes from loader-core
Diff Detail
Diff Detail
- Repository
- rDLDSVN Subversion (SVN) loader
- Branch
- tests-update
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 2847 Build 3591: tox-on-jenkins Jenkins Build 3590: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/12/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/12/console
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/21/ for more details.
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/22/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/22/console
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/23/ for more details.
| swh/loader/svn/tests/test_loader.py | ||
|---|---|---|
| 28 | What do you think of: if not loader:
loader = SvnLoaderMemoryStorage()
self.loader = loader | |
Comment Actions
Sounds good.
I have some not blocking question/remark.
| swh/loader/svn/tests/test_loader.py | ||
|---|---|---|
| 104 | Do we still do it that way? I mean, IIRC, it was there to override the svn loader to bypass the real connection with the collaborator storage (no in-memory at the time). Now that we are using the memory storage, we supposedly can set the collaborator memory storage up to do its job (here to not have any snapshot to return for the specified origin in that particular case). But that can also be done later ;) Note: I won't repeat this everywhere but that remark/question stands for all different loader implementations below ;) | |
Comment Actions
Update: Some refactoring
- Use a single class for test loader: SvnLoaderTest, taking the latest snapshot revision to return as parameter
- Slightly rename test classes
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/24/ for more details.
Comment Actions
I like how that clarifies where to look for the snapshots ;)
Thanks.
| swh/loader/svn/tests/test_loader.py | ||
|---|---|---|
| 28 | \m/ | |
| swh/loader/svn/tests/test_loader.py | ||
|---|---|---|
| 230 | rename in caps lock (that's a constant). Also probably split snapshot and revision. | |
| 236 | Replace with: super().setUp(loader=SvnLoaderTest) self.storage.revision_add([_last_snp_rev['revision']]) self.storage.snapshot_add([_last_snp_rev['snapshot']]) And remove/rename all occurences of last_snp_rev. | |
| 268–287 | kind of a duplicate of the global one. | |
| swh/loader/svn/tests/test_loader.py | ||
|---|---|---|
| 230 | ack | |
| 236 | Unfortunately, that's not so simple. I have just tested to remove the swh_latest_snapshot_revision override in the test loader class in favor of only relying to the in-memory storage but numerous errors appeared. So I will keep it this way for the moment. | |
| 268–287 | ack | |
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/25/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/25/console
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/26/ for more details.