Differential D6636

Add types to the svn module
ClosedPublic
Actions

Authored by ardumont on Nov 10 2021, 3:49 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T3719: loader svn fails to clean up properly disk when it crashes

Commits

rDLDSVN49cd7cc4fadb: Add types to the svn module

Summary

Related to T3719

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 25003
Build 39068: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 39067: arc lint + arc unit

Event Timeline

ardumont created this revision.Nov 10 2021, 3:49 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 10 2021, 3:49 PM

Build has FAILED

Patch application report for D6636 (id=24124)

Rebasing onto 0f70f07bc3...

Current branch diff-target is up to date.

Changes applied before test

commit cbb442cff73b2eda34f31f8f9c7c48a470cd6234
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Nov 10 15:45:58 2021 +0100

    Add types to the svn module
    
    Related to T3719

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/186/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/186/console

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 10 2021, 3:52 PM

Harbormaster failed remote builds in B25003: Diff 24124!

vlorentz added a subscriber: vlorentz.Nov 10 2021, 3:57 PM

vlorentz added inline comments.

swh/loader/svn/svn.py
170	need to update this
226–232	would make sense to add a data structure for this, at least a namedtuple

Fix doc build

Build is green

Patch application report for D6636 (id=24125)

Rebasing onto 0f70f07bc3...

Current branch diff-target is up to date.

Changes applied before test

commit b7ed7adf9ea50b4499acce2533ebba53c829e37f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Nov 10 15:45:58 2021 +0100

    Add types to the svn module
    
    Related to T3719

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/187/ for more details.

Harbormaster completed remote builds in B25004: Diff 24125.Nov 10 2021, 4:02 PM

ardumont requested review of this revision.Nov 10 2021, 4:02 PM

ardumont added inline comments.Nov 10 2021, 4:22 PM

swh/loader/svn/svn.py
226–232	yes, in another diff though if you don't mind (i'm lazy right now).

Cool, thanks !

This revision is now accepted and ready to land.Nov 17 2021, 10:57 AM

[don't remember the difference but the hash is different now]

Build is green

Patch application report for D6636 (id=24163)

Rebasing onto 65c6ae9e12...

Current branch diff-target is up to date.

Changes applied before test

commit 49cd7cc4fadb961d6eae46e33ac092d8a09c53c9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Nov 10 15:45:58 2021 +0100

    Add types to the svn module
    
    Related to T3719

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/190/ for more details.

Harbormaster completed remote builds in B25044: Diff 24163.Nov 17 2021, 11:03 AM

Closed by commit rDLDSVN49cd7cc4fadb: Add types to the svn module (authored by ardumont). · Explain WhyNov 17 2021, 11:03 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDSVN49cd7cc4fadb: Add types to the svn module.