Differential D6602

loader: Fix error when first revision number is not one
ClosedPublic
Actions

Authored by ardumont on Nov 3 2021, 6:07 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T3701: loading some svn origins while ignoring history sometimes raises

Commits

rDLDSVN51f4d54bdfd6: loader: Fix error when first revision number is not one

Summary

It exist cases where the first revision number returned by a subversion
server has a value greater than one.

The loader did not expect such cases in its current implementation and
was raising an error preventing the loading of such repository in the
archive (apart when using the SvnLoaderFromRemoteDump class which
always dumps revisions starting from number one).

So ensure to cover that case in loader implementation.

Related to T3701

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Branch

handle-first-revision-not-number-one

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24864
Build 38835: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 38834: arc lint + arc unit

Event Timeline

anlambert created this revision.Nov 3 2021, 6:07 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 3 2021, 6:07 PM

Build is green

Patch application report for D6602 (id=23990)

Rebasing onto b326099c73...

Current branch diff-target is up to date.

Changes applied before test

commit e921b70754ba6a85300369df97675bcc45a3abb3
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 3 17:59:29 2021 +0100

    loader: Fix error when first revision number is not one
    
    It exist cases where the first revision number returned by a subversion
    server has a value greater than one.
    
    The loader did not expect such cases in its current implementation and
    was raising an error preventing the loading of such repository in the
    archive (apart when using the SvnLoaderFromRemoteDump class which
    always dumps revisions starting from number one).
    
    So ensure to cover that case in loader implementation.
    
    Related to T3701

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/155/ for more details.

Harbormaster completed remote builds in B24864: Diff 23990.Nov 3 2021, 6:08 PM

anlambert requested review of this revision.Nov 3 2021, 6:08 PM

Any idea why this happens?

Update: Simplify test implementation

Build is green

Patch application report for D6602 (id=23992)

Rebasing onto b326099c73...

Current branch diff-target is up to date.

Changes applied before test

commit 94af4ab193d42b0676fc5e6c9ac6d6539b548d18
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 3 17:59:29 2021 +0100

    loader: Fix error when first revision number is not one
    
    It exist cases where the first revision number returned by a subversion
    server has a value greater than one.
    
    The loader did not expect such cases in its current implementation and
    was raising an error preventing the loading of such repository in the
    archive (apart when using the SvnLoaderFromRemoteDump class which
    always dumps revisions starting from number one).
    
    So ensure to cover that case in loader implementation.
    
    Related to T3701

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/156/ for more details.

Harbormaster completed remote builds in B24866: Diff 23992.Nov 4 2021, 10:49 AM

Any idea why this happens?

I suppose svnadmin configuration divergence is possible.

As an example, it's possible to share a svn repository for multiple projects...
(check the apache svn repository).

ardumont accepted this revision.Nov 8 2021, 12:29 PM

This revision is now accepted and ready to land.Nov 8 2021, 12:29 PM

ardumont commandeered this revision.Nov 8 2021, 3:00 PM

ardumont edited reviewers, added: anlambert; removed: ardumont.

This revision now requires review to proceed.Nov 8 2021, 3:00 PM

Rebase

Build is green

Patch application report for D6602 (id=24035)

Rebasing onto 057e00bf93...

Current branch diff-target is up to date.

Changes applied before test

commit 51f4d54bdfd611c51ed1a798e2e0c1ebad877860
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 3 17:59:29 2021 +0100

    loader: Fix error when first revision number is not one
    
    It exist cases where the first revision number returned by a subversion
    server has a value greater than one.
    
    The loader did not expect such cases in its current implementation and
    was raising an error preventing the loading of such repository in the
    archive (apart when using the SvnLoaderFromRemoteDump class which
    always dumps revisions starting from number one).
    
    So ensure to cover that case in loader implementation.
    
    Related to T3701

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/163/ for more details.

Harbormaster completed remote builds in B24909: Diff 24035.Nov 8 2021, 3:02 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 8 2021, 4:06 PM

Closed by commit rDLDSVN51f4d54bdfd6: loader: Fix error when first revision number is not one (authored by anlambert, committed by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDSVN51f4d54bdfd6: loader: Fix error when first revision number is not one.