Page MenuHomeSoftware Heritage
Differential D6581

loader: Rename ignore_history parameter to incremental
ClosedPublic
Actions

Authored by ardumont on Oct 28 2021, 3:15 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDLDG670e8c837e9e: loader: Rename ignore_history parameter to incremental
Summary

This:

  • unifies this parameter name with names similar to what's used in lister
  • also documents it better

Related to D6576

Test Plan

tox

Diff Detail

Repository
rDLDG Git loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24800
Build 38723: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 38722: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
14 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.git.tests.test_loader.TestDumbGitLoaderWithoutPack::test_load_empty_repository
request = <SubRequest 'swh_storage_postgresql' for <Function test_load_empty_repository>> @pytest.fixture
3,410 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.git.tests.test_tasks::test_git_loader
request = <SubRequest 'swh_storage_postgresql' for <Function test_git_loader>> @pytest.fixture
17 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.git.tests.test_tasks::test_git_loader_from_archive
request = <SubRequest 'swh_storage_postgresql' for <Function test_git_loader_from_archive>> @pytest.fixture
19 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.git.tests.test_tasks::test_git_loader_from_disk
request = <SubRequest 'swh_storage_postgresql' for <Function test_git_loader_from_disk>> @pytest.fixture
1 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.git.tests.test_converters.TestConverters::test_author_line_to_author
View Full Test Results (4 Failed · 124 Passed)

Event Timeline

ardumont created this revision.Oct 28 2021, 3:15 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 28 2021, 3:15 PM
swh-public-ci added a comment.Oct 28 2021, 3:17 PM

Build is green

Patch application report for D6581 (id=23919)

Rebasing onto a40f1e00cd...

Current branch diff-target is up to date.
Changes applied before test
commit 670e8c837e9e102e21b36c3267c99c291c94147c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 28 15:12:13 2021 +0200

    loader: Rename ignore_history parameter to incremental
    
    This:
    - unifies this parameter name with names similar to what's used in lister
    - also documents it better
    
    Related to T3695

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/152/ for more details.

Harbormaster completed remote builds in B24797: Diff 23919.Oct 28 2021, 3:17 PM
ardumont requested review of this revision.Oct 28 2021, 3:17 PM
vlorentz accepted this revision.Oct 28 2021, 3:18 PM
vlorentz added a subscriber: vlorentz.

thx

This revision is now accepted and ready to land.Oct 28 2021, 3:18 PM
ardumont updated this revision to Diff 23922.Oct 28 2021, 3:28 PM

Add missing coverage

ardumont updated this revision to Diff 23923.Oct 28 2021, 3:30 PM

Fix typos and mistyped assertion

swh-public-ci added a comment.Oct 28 2021, 3:31 PM

Build has FAILED

Patch application report for D6581 (id=23922)

Rebasing onto a40f1e00cd...

Current branch diff-target is up to date.
Changes applied before test
commit 9a2053de79bce8997609772bf27b0c565841757a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 28 15:12:13 2021 +0200

    loader: Rename ignore_history parameter to incremental
    
    This:
    - unifies this parameter name with names similar to what's used in lister
    - also documents it better
    
    Related to T3695

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/153/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/153/console

Harbormaster failed remote builds in B24800: Diff 23922!Oct 28 2021, 3:31 PM
swh-public-ci added a comment.Oct 28 2021, 3:33 PM

Build has FAILED

Patch application report for D6581 (id=23923)

Rebasing onto a40f1e00cd...

Current branch diff-target is up to date.
Changes applied before test
commit ea953c300b0c6b3ba54eec9d765fe9e8ac79162a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 28 15:12:13 2021 +0200

    loader: Rename ignore_history parameter to incremental
    
    This:
    - unifies this parameter name with names similar to what's used in lister
    - also documents it better
    
    Related to T3695

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/154/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/154/console

Harbormaster failed remote builds in B24801: Diff 23923!Oct 28 2021, 3:33 PM
ardumont updated this revision to Diff 23925.Oct 28 2021, 3:38 PM

Another tryout to add coverage, too much pg connection in previous iteration

swh-public-ci added a comment.Oct 28 2021, 3:40 PM

Build has FAILED

Patch application report for D6581 (id=23925)

Rebasing onto a40f1e00cd...

Current branch diff-target is up to date.
Changes applied before test
commit e39ea4c924cc4ace69807d4150f6b53a9add7d7a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 28 15:12:13 2021 +0200

    loader: Rename ignore_history parameter to incremental
    
    This:
    - unifies this parameter name with names similar to what's used in lister
    - also documents it better
    
    Related to T3695

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/155/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/155/console

Harbormaster failed remote builds in B24803: Diff 23925!Oct 28 2021, 3:40 PM
ardumont updated this revision to Diff 23926.Oct 28 2021, 3:42 PM

Revert coverage tryouts

swh-public-ci added a comment.Oct 28 2021, 3:46 PM

Build is green

Patch application report for D6581 (id=23926)

Rebasing onto a40f1e00cd...

Current branch diff-target is up to date.
Changes applied before test
commit 670e8c837e9e102e21b36c3267c99c291c94147c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 28 15:12:13 2021 +0200

    loader: Rename ignore_history parameter to incremental
    
    This:
    - unifies this parameter name with names similar to what's used in lister
    - also documents it better
    
    Related to T3695

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/156/ for more details.

Harbormaster completed remote builds in B24804: Diff 23926.Oct 28 2021, 3:46 PM
Closed by commit rDLDG670e8c837e9e: loader: Rename ignore_history parameter to incremental (authored by ardumont). · Explain WhyOct 28 2021, 3:49 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLDG670e8c837e9e: loader: Rename ignore_history parameter to incremental.

Revision Contents
Changeset List

PathSize
swh/
loader/
git/
25 lines
tests/
8 lines
7 lines

Diff 23922

View Options

swh/loader/git/loader.py

Loading...
View Options

swh/loader/git/tests/test_from_disk.py

Loading...
View Options

swh/loader/git/tests/test_loader.py

Loading...
About · Developer information · Legal