Page MenuHomeSoftware Heritage

loader: Rename ignore_history parameter to incremental
ClosedPublic

Authored by ardumont on Oct 28 2021, 3:15 PM.

Details

Summary

This:

  • unifies this parameter name with names similar to what's used in lister
  • also documents it better

Related to D6576

Test Plan

tox

Diff Detail

Repository
rDLDG Git loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6581 (id=23919)

Rebasing onto a40f1e00cd...

Current branch diff-target is up to date.
Changes applied before test
commit 670e8c837e9e102e21b36c3267c99c291c94147c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 28 15:12:13 2021 +0200

    loader: Rename ignore_history parameter to incremental
    
    This:
    - unifies this parameter name with names similar to what's used in lister
    - also documents it better
    
    Related to T3695

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/152/ for more details.

This revision is now accepted and ready to land.Oct 28 2021, 3:18 PM

Fix typos and mistyped assertion

Build has FAILED

Patch application report for D6581 (id=23922)

Rebasing onto a40f1e00cd...

Current branch diff-target is up to date.
Changes applied before test
commit 9a2053de79bce8997609772bf27b0c565841757a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 28 15:12:13 2021 +0200

    loader: Rename ignore_history parameter to incremental
    
    This:
    - unifies this parameter name with names similar to what's used in lister
    - also documents it better
    
    Related to T3695

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/153/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/153/console

Build has FAILED

Patch application report for D6581 (id=23923)

Rebasing onto a40f1e00cd...

Current branch diff-target is up to date.
Changes applied before test
commit ea953c300b0c6b3ba54eec9d765fe9e8ac79162a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 28 15:12:13 2021 +0200

    loader: Rename ignore_history parameter to incremental
    
    This:
    - unifies this parameter name with names similar to what's used in lister
    - also documents it better
    
    Related to T3695

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/154/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/154/console

Another tryout to add coverage, too much pg connection in previous iteration

Build has FAILED

Patch application report for D6581 (id=23925)

Rebasing onto a40f1e00cd...

Current branch diff-target is up to date.
Changes applied before test
commit e39ea4c924cc4ace69807d4150f6b53a9add7d7a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 28 15:12:13 2021 +0200

    loader: Rename ignore_history parameter to incremental
    
    This:
    - unifies this parameter name with names similar to what's used in lister
    - also documents it better
    
    Related to T3695

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/155/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/155/console

Build is green

Patch application report for D6581 (id=23926)

Rebasing onto a40f1e00cd...

Current branch diff-target is up to date.
Changes applied before test
commit 670e8c837e9e102e21b36c3267c99c291c94147c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 28 15:12:13 2021 +0200

    loader: Rename ignore_history parameter to incremental
    
    This:
    - unifies this parameter name with names similar to what's used in lister
    - also documents it better
    
    Related to T3695

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/156/ for more details.