Page MenuHomeSoftware Heritage

Rename imports of swh.model.identifiers to fix deprecation warnings.
ClosedPublic

Authored by vlorentz on Oct 5 2021, 3:07 PM.

Diff Detail

Repository
rDDEP Push deposit
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24231
Build 37819: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 37818: arc lint + arc unit

Unit TestsFailed

TimeTest
284 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_deposit_private_read_metadata::test_read_metadata
authenticated_client = <rest_framework.test.APIClient object at 0x7fbd4c7c1dd8> deposit_collection = <DepositCollection: {'id': 109, 'name': 'test'}> partial_deposit = <Deposit: {'id': 83, 'reception_date': datetime.datetime(2021, 10, 5, 13, 20, 46, 619813, tzinfo=<UTC>), 'collection':...al-id', 'origin_url': 'https://hal-test.archives-ouvertes.fr/some-external-id', 'client': 'test', 'status': 'partial'}>
310 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_deposit_private_read_metadata::test_read_metadata_3
authenticated_client = <rest_framework.test.APIClient object at 0x7fbd4c5d1c88> deposit_collection = <DepositCollection: {'id': 111, 'name': 'test'}> partial_deposit = <Deposit: {'id': 86, 'reception_date': datetime.datetime(2021, 10, 5, 13, 20, 47, 668546, tzinfo=<UTC>), 'collection':...-01243065', 'origin_url': 'https://hal-test.archives-ouvertes.fr/hal-01243065', 'client': 'test', 'status': 'partial'}>
257 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_deposit_private_read_metadata::test_read_metadata_4
authenticated_client = <rest_framework.test.APIClient object at 0x7fbd4c8811d0> deposit_collection = <DepositCollection: {'id': 112, 'name': 'test'}> atom_dataset = {'codemeta-sample': '<?xml version="1.0"?>\n <entry xmlns="http://www.w3.org/2005/Atom"\n xmlns:d...ntry>\n', 'entry-data-empty-body': '<?xml version="1.0"?>\n<entry xmlns="http://www.w3.org/2005/Atom"></entry>\n', ...}
238 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_deposit_private_read_metadata::test_read_metadata_5
authenticated_client = <rest_framework.test.APIClient object at 0x7fbd4d36cfd0> deposit_collection = <DepositCollection: {'id': 113, 'name': 'test'}> partial_deposit = <Deposit: {'id': 88, 'reception_date': datetime.datetime(2021, 10, 5, 13, 20, 48, 611764, tzinfo=<UTC>), 'collection': 'test', 'external_id': 'external-id-partial', 'origin_url': None, 'client': 'test', 'status': 'partial'}>
273 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_deposit_private_read_metadata::test_read_metadata_revision_with_parent
authenticated_client = <rest_framework.test.APIClient object at 0x7fbd4d38cc88> deposit_collection = <DepositCollection: {'id': 110, 'name': 'test'}> partial_deposit = <Deposit: {'id': 84, 'reception_date': datetime.datetime(2021, 10, 5, 13, 20, 47, 237212, tzinfo=<UTC>), 'collection':...al-id', 'origin_url': 'https://hal-test.archives-ouvertes.fr/some-external-id', 'client': 'test', 'status': 'partial'}>
View Full Test Results (5 Failed · 276 Passed)

Event Timeline

Build has FAILED

Patch application report for D6413 (id=23317)

Rebasing onto d1b840de26...

Current branch diff-target is up to date.
Changes applied before test
commit 222a3c24e7c943a31583e891726ccfcf9e1e44fe
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Oct 5 15:07:12 2021 +0200

    Rename imports of swh.model.identifiers to fix deprecation warnings.

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/677/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/677/console

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 5 2021, 3:10 PM
Harbormaster failed remote builds in B24230: Diff 23317!

Build has FAILED

Patch application report for D6413 (id=23318)

Rebasing onto d1b840de26...

Current branch diff-target is up to date.
Changes applied before test
commit 130af40df6c26b73fa30ca78db9902f4ad3965e1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Oct 5 15:07:12 2021 +0200

    Rename imports of swh.model.identifiers to fix deprecation warnings.

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/678/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/678/console

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 5 2021, 3:21 PM
Harbormaster failed remote builds in B24231: Diff 23318!

rebase on D6418 to have working tests

Build is green

Patch application report for D6413 (id=23335)

Could not rebase; Attempt merge onto d1b840de26...

Updating d1b840de..179dff0d
Fast-forward
 requirements-swh.txt                               |  2 +-
 swh/deposit/api/common.py                          | 12 +++---
 swh/deposit/api/edit.py                            |  2 +-
 swh/deposit/api/private/deposit_update_status.py   |  2 +-
 swh/deposit/migrations/0018_migrate_swhids.py      |  2 +-
 swh/deposit/tests/api/test_collection_post_atom.py |  2 +-
 swh/deposit/tests/api/test_deposit_update_atom.py  |  2 +-
 swh/deposit/tests/conftest.py                      |  2 +-
 swh/deposit/tests/test_utils.py                    | 49 +++++++++-------------
 swh/deposit/utils.py                               | 12 ++----
 10 files changed, 36 insertions(+), 51 deletions(-)
Changes applied before test
commit 179dff0dfaa4e906354d596cf9669347fe340e87
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Oct 6 13:12:41 2021 +0200

    Rename imports of swh.model.identifiers to fix deprecation warnings.

commit 915c877fd7dfdf451169254c2e6c494341a48c6b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Oct 6 13:11:18 2021 +0200

    test_utils.py: Remove incorrect mocks

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/680/ for more details.

This revision is now accepted and ready to land.Oct 6 2021, 4:43 PM