Differential D6413

Rename imports of swh.model.identifiers to fix deprecation warnings.
ClosedPublic
Actions

Authored by vlorentz on Oct 5 2021, 3:07 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDDEP179dff0dfaa4: Rename imports of swh.model.identifiers to fix deprecation warnings.

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Oct 5 2021, 3:07 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 5 2021, 3:07 PM

Build has FAILED

Patch application report for D6413 (id=23317)

Rebasing onto d1b840de26...

Current branch diff-target is up to date.

Changes applied before test

commit 222a3c24e7c943a31583e891726ccfcf9e1e44fe
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Oct 5 15:07:12 2021 +0200

    Rename imports of swh.model.identifiers to fix deprecation warnings.

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/677/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/677/console

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 5 2021, 3:10 PM

Harbormaster failed remote builds in B24230: Diff 23317!

fix tests

Build has FAILED

Patch application report for D6413 (id=23318)

Rebasing onto d1b840de26...

Current branch diff-target is up to date.

Changes applied before test

commit 130af40df6c26b73fa30ca78db9902f4ad3965e1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Oct 5 15:07:12 2021 +0200

    Rename imports of swh.model.identifiers to fix deprecation warnings.

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/678/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/678/console

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 5 2021, 3:21 PM

Harbormaster failed remote builds in B24231: Diff 23318!

rebase on D6418 to have working tests

vlorentz added a parent revision: D6418: test_utils.py: Remove incorrect mocks.Oct 6 2021, 1:13 PM

Build is green

Patch application report for D6413 (id=23335)

Could not rebase; Attempt merge onto d1b840de26...

Updating d1b840de..179dff0d
Fast-forward
 requirements-swh.txt                               |  2 +-
 swh/deposit/api/common.py                          | 12 +++---
 swh/deposit/api/edit.py                            |  2 +-
 swh/deposit/api/private/deposit_update_status.py   |  2 +-
 swh/deposit/migrations/0018_migrate_swhids.py      |  2 +-
 swh/deposit/tests/api/test_collection_post_atom.py |  2 +-
 swh/deposit/tests/api/test_deposit_update_atom.py  |  2 +-
 swh/deposit/tests/conftest.py                      |  2 +-
 swh/deposit/tests/test_utils.py                    | 49 +++++++++-------------
 swh/deposit/utils.py                               | 12 ++----
 10 files changed, 36 insertions(+), 51 deletions(-)

Changes applied before test

commit 179dff0dfaa4e906354d596cf9669347fe340e87
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Oct 6 13:12:41 2021 +0200

    Rename imports of swh.model.identifiers to fix deprecation warnings.

commit 915c877fd7dfdf451169254c2e6c494341a48c6b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Oct 6 13:11:18 2021 +0200

    test_utils.py: Remove incorrect mocks

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/680/ for more details.

Harbormaster completed remote builds in B24248: Diff 23335.Oct 6 2021, 1:16 PM

vlorentz requested review of this revision.Oct 6 2021, 1:16 PM

ardumont accepted this revision.Oct 6 2021, 4:43 PM

This revision is now accepted and ready to land.Oct 6 2021, 4:43 PM

Closed by commit rDDEP179dff0dfaa4: Rename imports of swh.model.identifiers to fix deprecation warnings. (authored by vlorentz). · Explain WhyOct 7 2021, 10:16 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDDEP179dff0dfaa4: Rename imports of swh.model.identifiers to fix deprecation warnings..