postgresql: Fix get_snapshot_branches return value for empty search
ClosedPublic
Actions

Authored by anlambert on Sep 16 2021, 2:15 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T3413: Fix the inconsistency between snapshot_get_branches function in postgresql.storage and cassandra.storage

Commits

rDSTO9465054ef003: postgresql: Fix get_snapshot_branches return value for empty search

Summary

When searching for branches in an existing snapshot, a PartialBranches
object must be returned regardless the number of found branches.

None should only be returned when a snapshot does not exist.

This fixes an inconsistency between the postgresql and cassandra
backends.

This will also fix that webapp reported issue.

Related to T3413

Diff Detail

Repository

rDSTO Storage manager

Branch

postgresql-get-snapshot-branches-fix

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 23682
Build 36968: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 36967: arc lint + arc unit

Event Timeline

anlambert created this revision.Sep 16 2021, 2:15 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 16 2021, 2:15 PM

Build is green

Patch application report for D6283 (id=22750)

Rebasing onto a9fde72c48...

Current branch diff-target is up to date.

Changes applied before test

commit 9465054ef0030f33014d170bdcfaf8f4023eb47e
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Sep 16 14:08:33 2021 +0200

    postgresql: Fix get_snapshot_branches return value for empty search
    
    When searching for branches in an existing snapshot, a PartialBranches
    object must be returned regardless the number of found branches.
    
    None should only be returned when a snapshot does not exist.
    
    This fixes an inconsistency between the postgresql and cassandra
    backends.
    
    Related to T3413

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1416/ for more details.

Harbormaster completed remote builds in B23682: Diff 22750.Sep 16 2021, 2:23 PM

anlambert requested review of this revision.Sep 16 2021, 2:23 PM

vlorentz accepted this revision.Sep 16 2021, 2:59 PM

This revision is now accepted and ready to land.Sep 16 2021, 2:59 PM

Closed by commit rDSTO9465054ef003: postgresql: Fix get_snapshot_branches return value for empty search (authored by anlambert). · Explain WhySep 16 2021, 3:02 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDSTO9465054ef003: postgresql: Fix get_snapshot_branches return value for empty search.