Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDCORE02bf96407ff4: tarball/uncompress: Ensure destination folder exists before unpacking
Diff Detail
Diff Detail
- Repository
- rDCORE Foundations and core functionalities
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 21939 Build 34124: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 34123: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D5857 (id=20960)
Could not rebase; Attempt merge onto cbf07d953e...
Updating cbf07d9..02bf964 Fast-forward swh/core/tarball.py | 9 ++++---- swh/core/tests/test_tarball.py | 50 +++++------------------------------------- 2 files changed, 10 insertions(+), 49 deletions(-)
Changes applied before test
commit 02bf96407ff4c619a76644c4675807e90fea699e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Fri Jun 11 15:31:55 2021 +0200
tarball/uncompress: Ensure destination folder exists before unpacking
commit 14f8c4296819d6c3de1cfee5d81d9081aa6668e7
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Fri Jun 11 15:23:26 2021 +0200
tests/tarball: Use uncompress function instead of private ones
Do not leak internal swh.core.tarball implementation in tests.
Also fix swh.core.tarball.uncompress documentation and implementation,
the function should not return a value.See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/232/ for more details.
Comment Actions
Build is green
Patch application report for D5857 (id=20960)
Could not rebase; Attempt merge onto cbf07d953e...
Updating cbf07d9..02bf964 Fast-forward swh/core/tarball.py | 9 ++++---- swh/core/tests/test_tarball.py | 50 +++++------------------------------------- 2 files changed, 10 insertions(+), 49 deletions(-)
Changes applied before test
commit 02bf96407ff4c619a76644c4675807e90fea699e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Fri Jun 11 15:31:55 2021 +0200
tarball/uncompress: Ensure destination folder exists before unpacking
commit 14f8c4296819d6c3de1cfee5d81d9081aa6668e7
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Fri Jun 11 15:23:26 2021 +0200
tests/tarball: Use uncompress function instead of private ones
Do not leak internal swh.core.tarball implementation in tests.
Also fix swh.core.tarball.uncompress documentation and implementation,
the function should not return a value.See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/233/ for more details.