Differential D5650
identifiers: Expose manifest computation Authored by vlorentz on Apr 30 2021, 11:30 AM.
Details
Before this commit, manifests were only computed internally before This makes testing the module very painful, because identifier Additionally, the 'git bare cooker' of the vault is likely to use Should I add specific tests for the new manifest functions?
Diff Detail
Event TimelineComment Actions Build has FAILED Patch application report for D5650 (id=20181)Rebasing onto f7e9d5c290... Current branch diff-target is up to date. Changes applied before testcommit 4eb74157df01fddb980850671b33cae51a2cdb44
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Apr 30 11:26:32 2021 +0200
identifiers: Expose manifest computation
Before this commit, manifests were only computed internally before
hashing, so they were not available to outside modules.
This makes testing the module very painful, because identifier
functions can only be tested by checking the hash; so test failures
did not show mismatches between the computed manifest and
the expected one.
Additionally, the 'git bare cooker' of the vault is likely to use
these as well, as it needs to format git objects in the same format.Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/324/ Comment Actions Build is green Patch application report for D5650 (id=20185)Rebasing onto f7e9d5c290... Current branch diff-target is up to date. Changes applied before testcommit 3a4f484feaccd569a0b9dc37531d7af50bc3871e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Apr 30 11:26:32 2021 +0200
identifiers: Expose manifest computation
Before this commit, manifests were only computed internally before
hashing, so they were not available to outside modules.
This makes testing the module very painful, because identifier
functions can only be tested by checking the hash; so test failures
did not show mismatches between the computed manifest and
the expected one.
Additionally, the 'git bare cooker' of the vault is likely to use
these as well, as it needs to format git objects in the same format.See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/325/ for more details. Comment Actions Build is green Patch application report for D5650 (id=20203)Rebasing onto df036ef1c3... Current branch diff-target is up to date. Changes applied before testcommit 8221147ce6e74b3f685baead1906675b3454065c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Apr 30 11:26:32 2021 +0200
identifiers: Expose manifest computation
Before this commit, manifests were only computed internally before
hashing, so they were not available to outside modules.
This makes testing the module very painful, because identifier
functions can only be tested by checking the hash; so test failures
did not show mismatches between the computed manifest and
the expected one.
Additionally, the 'git bare cooker' of the vault is likely to use
these as well, as it needs to format git objects in the same format.See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/331/ for more details. Comment Actions Build is green Patch application report for D5650 (id=20475)Rebasing onto 31cb72e9f0... Current branch diff-target is up to date. Changes applied before testcommit 523ab642bb48491f8e09fb61cc32a9e11420b556
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Apr 30 11:26:32 2021 +0200
identifiers: Expose manifest computation
Before this commit, manifests were only computed internally before
hashing, so they were not available to outside modules.
This makes testing the module very painful, because identifier
functions can only be tested by checking the hash; so test failures
did not show mismatches between the computed manifest and
the expected one.
Additionally, the 'git bare cooker' of the vault is likely to use
these as well, as it needs to format git objects in the same format.See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/334/ for more details. |