Page MenuHomeSoftware Heritage

cassandra: Add tests checking directory_add and snapshot_add are atomic.
ClosedPublic

Authored by vlorentz on May 10 2021, 2:13 PM.

Diff Detail

Repository
rDSTO Storage manager
Branch
snpdir-missing
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21408
Build 33252: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 33251: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D5720 (id=20431)

Rebasing onto 761709957a...

Current branch diff-target is up to date.
Changes applied before test
commit 4d3eeb2edd5b1413a968a30b1b0f585be4dcf4e0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon May 10 14:13:20 2021 +0200

    cassandra: Add tests checking directory_add and snapshot_add are atomic.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1317/ for more details.

ardumont added a subscriber: ardumont.

Ok.

Some questions though:

  • Why is this limited to directory and snapshot?
  • Why is this limited to the cassandra backend?
This revision is now accepted and ready to land.May 10 2021, 5:48 PM
  • Why is this limited to directory and snapshot?

They are the only ones with multiple rows per object (other than indices)

  • Why is this limited to the cassandra backend?

Because we implement transactionality ourselves in the cassandra backend, but rely on postgresql transactions in the postgresql backend.

  • Why is this limited to directory and snapshot?

They are the only ones with multiple rows per object (other than indices)

  • Why is this limited to the cassandra backend?

Because we implement transactionality ourselves in the cassandra backend, but rely on postgresql transactions in the postgresql backend.

Thanks for clarifying ;)

Build is green

Patch application report for D5720 (id=20473)

Rebasing onto b487a21f27...

Current branch diff-target is up to date.
Changes applied before test
commit f140f634b63d53773a016c493eff6ed153e24acc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon May 10 14:13:20 2021 +0200

    cassandra: Add tests checking directory_add and snapshot_add are atomic.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1323/ for more details.