Differential D5720

cassandra: Add tests checking directory_add and snapshot_add are atomic.
ClosedPublic
Actions

Authored by vlorentz on May 10 2021, 2:13 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSTOf140f634b63d: cassandra: Add tests checking directory_add and snapshot_add are atomic.

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.May 10 2021, 2:13 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 10 2021, 2:13 PM

Build is green

Patch application report for D5720 (id=20431)

Rebasing onto 761709957a...

Current branch diff-target is up to date.

Changes applied before test

commit 4d3eeb2edd5b1413a968a30b1b0f585be4dcf4e0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon May 10 14:13:20 2021 +0200

    cassandra: Add tests checking directory_add and snapshot_add are atomic.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1317/ for more details.

Harbormaster completed remote builds in B21408: Diff 20431.May 10 2021, 2:21 PM

vlorentz requested review of this revision.May 10 2021, 2:21 PM

Ok.

Some questions though:

Why is this limited to directory and snapshot?
Why is this limited to the cassandra backend?

This revision is now accepted and ready to land.May 10 2021, 5:48 PM

In D5720#145521, @ardumont wrote:

Why is this limited to directory and snapshot?

They are the only ones with multiple rows per object (other than indices)

Why is this limited to the cassandra backend?

Because we implement transactionality ourselves in the cassandra backend, but rely on postgresql transactions in the postgresql backend.

Why is this limited to directory and snapshot?

They are the only ones with multiple rows per object (other than indices)

Why is this limited to the cassandra backend?

Because we implement transactionality ourselves in the cassandra backend, but rely on postgresql transactions in the postgresql backend.

Thanks for clarifying ;)

rebase

Build is green

Patch application report for D5720 (id=20473)

Rebasing onto b487a21f27...

Current branch diff-target is up to date.

Changes applied before test

commit f140f634b63d53773a016c493eff6ed153e24acc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon May 10 14:13:20 2021 +0200

    cassandra: Add tests checking directory_add and snapshot_add are atomic.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1323/ for more details.

Harbormaster completed remote builds in B21447: Diff 20473.May 11 2021, 10:30 AM

Closed by commit rDSTOf140f634b63d: cassandra: Add tests checking directory_add and snapshot_add are atomic. (authored by vlorentz). · Explain WhyMay 11 2021, 11:53 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTOf140f634b63d: cassandra: Add tests checking directory_add and snapshot_add are atomic..