Differential D5660

origin_save: Bypass unknown origins review for swh ambassador users
ClosedPublic
Actions

Authored by anlambert on May 3 2021, 1:54 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3213: Enable save code now of software source code archives for specific users

Commits

rDWAPPS8439eb5c9b89: origin_save: Bypass unknown origins review for swh ambassador users

Summary

As a first special save code now feature for swh ambassadors, bypass
the manual URL review for not trusted origins.

Related to T3213

Diff Detail

Repository

rDWAPPS Web applications

Branch

save-code-now-ambassador-no-pending-review

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 21208
Build 32924: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 32923: arc lint + arc unit

Event Timeline

anlambert created this revision.May 3 2021, 1:54 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 3 2021, 1:54 PM

Build is green

Patch application report for D5660 (id=20218)

Rebasing onto 88c003b85b...

Current branch diff-target is up to date.

Changes applied before test

commit b9e891c3ba167504f93688c3db46bbc00ed376f0
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Apr 30 14:37:10 2021 +0200

    origin_save: Bypass unknown origins review for swh ambassador users
    
    As a first special save code now feature for swh ambassadors, bypass
    the manual URL review for not trusted origins.
    
    Related to T3213

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/761/ for more details.

Harbormaster completed remote builds in B21208: Diff 20218.May 3 2021, 2:03 PM

anlambert requested review of this revision.May 3 2021, 2:03 PM

lgtm

I wonder if as a second step, such url could (or should) be added in the trusting urls altogether?

This revision is now accepted and ready to land.May 3 2021, 2:15 PM

In D5660#143705, @ardumont wrote:

lgtm

I wonder if as a second step, such url could (or should) be added in the trusting urls altogether?

Good idea, I will update that diff accordingly.

Update: Add origin URL submitted by an ambassador to the trust list.

great ;)

This revision was landed with ongoing or failed builds.May 3 2021, 2:41 PM

Closed by commit rDWAPPS8439eb5c9b89: origin_save: Bypass unknown origins review for swh ambassador users (authored by anlambert). · Explain Why

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS8439eb5c9b89: origin_save: Bypass unknown origins review for swh ambassador users.

Build has FAILED

Patch application report for D5660 (id=20219)

Rebasing onto 88c003b85b...

Current branch diff-target is up to date.

Changes applied before test

commit 8439eb5c9b89f096b7d79a1492af8c3df6f38d7c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Apr 30 14:37:10 2021 +0200

    origin_save: Bypass unknown origins review for swh ambassador users
    
    As a first special save code now feature for swh ambassadors, bypass
    the manual URL review for not trusted origins.
    
    Also add origin URLs submitted by ambassadors in the trusted origins
    list.
    
    Related to T3213

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/762/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/762/console

Harbormaster failed remote builds in B21209: Diff 20219!May 3 2021, 2:45 PM