Page MenuHomeSoftware Heritage

origin_save: Bypass unknown origins review for swh ambassador users
ClosedPublic

Authored by anlambert on Mon, May 3, 1:54 PM.

Details

Summary

As a first special save code now feature for swh ambassadors, bypass
the manual URL review for not trusted origins.

Related to T3213

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D5660 (id=20218)

Rebasing onto 88c003b85b...

Current branch diff-target is up to date.
Changes applied before test
commit b9e891c3ba167504f93688c3db46bbc00ed376f0
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Apr 30 14:37:10 2021 +0200

    origin_save: Bypass unknown origins review for swh ambassador users
    
    As a first special save code now feature for swh ambassadors, bypass
    the manual URL review for not trusted origins.
    
    Related to T3213

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/761/ for more details.

ardumont added a subscriber: ardumont.

lgtm

I wonder if as a second step, such url could (or should) be added in the trusting urls altogether?

This revision is now accepted and ready to land.Mon, May 3, 2:15 PM

lgtm

I wonder if as a second step, such url could (or should) be added in the trusting urls altogether?

Good idea, I will update that diff accordingly.

Update: Add origin URL submitted by an ambassador to the trust list.

This revision was landed with ongoing or failed builds.Mon, May 3, 2:41 PM
This revision was automatically updated to reflect the committed changes.

Build has FAILED

Patch application report for D5660 (id=20219)

Rebasing onto 88c003b85b...

Current branch diff-target is up to date.
Changes applied before test
commit 8439eb5c9b89f096b7d79a1492af8c3df6f38d7c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Apr 30 14:37:10 2021 +0200

    origin_save: Bypass unknown origins review for swh ambassador users
    
    As a first special save code now feature for swh ambassadors, bypass
    the manual URL review for not trusted origins.
    
    Also add origin URLs submitted by ambassadors in the trusted origins
    list.
    
    Related to T3213

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/762/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/762/console