Differential D636

Rename the 'ts' argument of 'origin_visit_add' to 'date'.
ClosedPublic
Actions

Authored by vlorentz on Nov 8 2018, 2:31 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDSTOC19d4019e21c0: Rename the 'ts' argument of 'origin_visit_add' to 'date'.
R65:19d4019e21c0: Rename the 'ts' argument of 'origin_visit_add' to 'date'.
rDSTO19d4019e21c0: Rename the 'ts' argument of 'origin_visit_add' to 'date'.

Summary

To be consistent with the name used in the DB and the dict
key returned by 'origin_visit_get'.

Note that this makes the client incompatible with older
versions of the server.

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 8 2018, 2:31 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 8 2018, 2:31 PM

Remove debug code.

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/40/ for more details.

Harbormaster completed remote builds in B2265: Diff 1971.Nov 8 2018, 2:36 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/41/ for more details.

Harbormaster completed remote builds in B2266: Diff 1972.Nov 8 2018, 2:40 PM

vlorentz added a child revision: D635: [WIP] In-memory storage implementation.Nov 8 2018, 2:46 PM

If the client is made incompatible with the old server, I'm not sure the DeprecationWarning dance is all that useful: all swh.storage consumers in production use the client/server API, and we'd have to deploy the change to every loader at the same time.

There shouldn't be that many users of origin_visit_add to fix.

Apart from that the change looks sensible.

The change should be deployed to the server first, and then consumers can be updated later

In D636#12814, @vlorentz wrote:

The change should be deployed to the server first, and then consumers can be updated later

Fair enough.

This revision is now accepted and ready to land.Nov 9 2018, 11:44 AM

Closed by commit rDSTO19d4019e21c0: Rename the 'ts' argument of 'origin_visit_add' to 'date'. (authored by vlorentz). · Explain WhyNov 9 2018, 11:45 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

storage/

api/

14 lines

25 lines

tests/

test_storage.py

14 lines

Diff 1987

swh/storage/api/client.py

Loading...

swh/storage/storage.py

Loading...

swh/storage/tests/test_storage.py

Loading...