Page MenuHomeSoftware Heritage
Differential D635

[WIP] In-memory storage implementation
AbandonedPublic
Actions

Authored by vlorentz on Nov 7 2018, 5:35 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Summary

This is a very work in progress in-memory storage implementation, to
help discussion around T1306 and D631.

The test data refactoring should be split off in another diff but the
scaffolding is really starting to get painful.

Test Plan

Some of the (easy) tests pass; for now all tests are marked xfail,
use pytest --runxfail to show tracebacks and try to fix them.

Diff Detail

Repository
rDSTO Storage manager
Branch
arcpatch-D635
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2286
Build 2763: tox-on-jenkinsJenkins
Build 2762: arc lint + arc unit

Event Timeline

olasd created this revision.Nov 7 2018, 5:35 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 7 2018, 5:35 PM
olasd planned changes to this revision.Nov 7 2018, 5:35 PM
swh-public-ci added a subscriber: swh-public-ci.Nov 7 2018, 5:36 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/36/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/36/console

Harbormaster failed remote builds in B2259: Diff 1966!Nov 7 2018, 5:36 PM
vlorentz mentioned this in D631: Make Storage, Db, and tests more modular..Nov 7 2018, 6:49 PM
vlorentz commandeered this revision.Nov 7 2018, 6:54 PM
vlorentz added a reviewer: olasd.
vlorentz updated this revision to Diff 1968.Nov 8 2018, 11:40 AM
  • Some progress.
vlorentz planned changes to this revision.Nov 8 2018, 11:41 AM
swh-public-ci added a comment.Nov 8 2018, 11:41 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/37/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/37/console

Harbormaster failed remote builds in B2262: Diff 1968!Nov 8 2018, 11:41 AM
vlorentz updated this revision to Diff 1969.Nov 8 2018, 11:43 AM
  • Make flake8 happy.
vlorentz planned changes to this revision.Nov 8 2018, 11:43 AM
Harbormaster completed remote builds in B2263: Diff 1969.Nov 8 2018, 11:47 AM
swh-public-ci added a comment.Nov 8 2018, 11:47 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/38/ for more details.

vlorentz added a parent revision: D636: Rename the 'ts' argument of 'origin_visit_add' to 'date'..Nov 8 2018, 2:46 PM
vlorentz updated this revision to Diff 1976.Nov 8 2018, 4:59 PM
  • More progress.
  • Add release-related methods.
  • Rename the 'ts' argument of 'origin_visit_add' to 'date'.
  • Add origin_visit_get.
  • Document metadata providers.
  • Add origin_get and metadata_provider-related methods.
  • Add origin_metadata-related methods.
  • Add origin_search.
  • Fix pg tests.
  • Add object_find_by_sha1_git.
vlorentz planned changes to this revision.Nov 8 2018, 4:59 PM
swh-public-ci added a comment.Nov 8 2018, 5:04 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/45/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/45/console

Harbormaster failed remote builds in B2273: Diff 1976!Nov 8 2018, 5:04 PM
vlorentz updated this revision to Diff 1981.Nov 9 2018, 11:08 AM
  • Detect hash collisions.
  • Fix remaining tests.
vlorentz updated this revision to Diff 1983.Nov 9 2018, 11:12 AM
  • Skip test_stat_counters in remote API test.
  • un-mark xfail.
swh-public-ci added a comment.Nov 9 2018, 11:13 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/46/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/46/console

Harbormaster failed remote builds in B2278: Diff 1981!Nov 9 2018, 11:13 AM
swh-public-ci added a comment.Nov 9 2018, 11:17 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/47/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/47/console

Harbormaster failed remote builds in B2280: Diff 1983!Nov 9 2018, 11:17 AM
vlorentz updated this revision to Diff 1988.Nov 9 2018, 11:46 AM
  • Rebase
swh-public-ci added a comment.Nov 9 2018, 11:52 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/48/ for more details.

Harbormaster completed remote builds in B2286: Diff 1988.Nov 9 2018, 11:52 AM
vlorentz added a comment.Nov 9 2018, 1:01 PM

Replaced by D642, D643, D644, D645

vlorentz abandoned this revision.Nov 9 2018, 1:01 PM

Revision Contents
Changeset List

PathSize
swh/
storage/
2 lines
1102 lines
59 lines
tests/
10 lines
31 lines
95 lines

Diff 1988

View Options

swh/storage/db.py

Loading...
View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/storage.py

Loading...
View Options

swh/storage/tests/test_api_client.py

Loading...
View Options

swh/storage/tests/test_in_memory.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal