Page MenuHomeSoftware Heritage

Rename the 'ts' argument of 'origin_visit_add' to 'date'.
ClosedPublic

Authored by vlorentz on Nov 8 2018, 2:31 PM.

Details

Summary

To be consistent with the name used in the DB and the dict
key returned by 'origin_visit_get'.

Note that this makes the client incompatible with older
versions of the server.

Diff Detail

Repository
rDSTO Storage manager
Branch
rename-ts-to-date
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2266
Build 2731: tox-on-jenkinsJenkins
Build 2730: arc lint + arc unit

Event Timeline

If the client is made incompatible with the old server, I'm not sure the DeprecationWarning dance is all that useful: all swh.storage consumers in production use the client/server API, and we'd have to deploy the change to every loader at the same time.

There shouldn't be that many users of origin_visit_add to fix.

Apart from that the change looks sensible.

The change should be deployed to the server first, and then consumers can be updated later

The change should be deployed to the server first, and then consumers can be updated later

Fair enough.

This revision is now accepted and ready to land.Nov 9 2018, 11:44 AM
This revision was automatically updated to reflect the committed changes.