Differential D5335

tests: Rename keycloak_mock fixture to keycloak_oidc
ClosedPublic
Actions

Authored by anlambert on Mar 25 2021, 1:58 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDAUTHdb5388d38a6a: tests: Rename keycloak_mock fixture to keycloak_oidc

Summary

Let's start to apply recommended guidelines when writing tests.

See "Don't give mock/stubs/fakes special names" section.

Diff Detail

Repository

rDAUTH Common authentication libraries

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Mar 25 2021, 1:58 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 25 2021, 1:58 PM

Build is green

Patch application report for D5335 (id=19128)

Rebasing onto b1e0415698...

Current branch diff-target is up to date.

Changes applied before test

commit dc33050a245e1d0d78383752fb0827d352f21625
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Mar 25 13:52:00 2021 +0100

    tests: Rename keycloak_mock fixture to keycloak_oidc
    
    Let's start to apply recommended guidelines when writing tests.

See https://jenkins.softwareheritage.org/job/DAUTH/job/tests-on-diff/53/ for more details.

Harbormaster completed remote builds in B20213: Diff 19128.Mar 25 2021, 1:59 PM

anlambert requested review of this revision.Mar 25 2021, 1:59 PM

That will break deposit tests though (i gather you will deal with the webapp ones soon).

Can we keep aliases on old names to avoid the temporary breakage?

In D5335#135635, @ardumont wrote:

ok

That will break deposit tests though (i gather you will deal with the webapp ones soon).

Can we keep aliases on old names to avoid the temporary breakage?

Sure, will update the diff.

Ensure backaward compatibility with old function name

Build is green

Patch application report for D5335 (id=19131)

Rebasing onto b1e0415698...

Current branch diff-target is up to date.

Changes applied before test

commit db5388d38a6a591d0d9d8bc35a440e13f62cac53
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Mar 25 13:52:00 2021 +0100

    tests: Rename keycloak_mock fixture to keycloak_oidc
    
    Let's start to apply recommended guidelines when writing tests.

See https://jenkins.softwareheritage.org/job/DAUTH/job/tests-on-diff/54/ for more details.

Harbormaster completed remote builds in B20216: Diff 19131.Mar 25 2021, 2:25 PM

Thanks.

This revision is now accepted and ready to land.Mar 25 2021, 2:27 PM

Closed by commit rDAUTHdb5388d38a6a: tests: Rename keycloak_mock fixture to keycloak_oidc (authored by anlambert). · Explain WhyMar 25 2021, 5:11 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDAUTHdb5388d38a6a: tests: Rename keycloak_mock fixture to keycloak_oidc.