Page MenuHomeSoftware Heritage

tests: Rename keycloak_mock fixture to keycloak_oidc
ClosedPublic

Authored by anlambert on Mar 25 2021, 1:58 PM.

Details

Summary

Let's start to apply recommended guidelines when writing tests.

See "Don't give mock/stubs/fakes special names" section.

Diff Detail

Event Timeline

Build is green

Patch application report for D5335 (id=19128)

Rebasing onto b1e0415698...

Current branch diff-target is up to date.
Changes applied before test
commit dc33050a245e1d0d78383752fb0827d352f21625
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Mar 25 13:52:00 2021 +0100

    tests: Rename keycloak_mock fixture to keycloak_oidc
    
    Let's start to apply recommended guidelines when writing tests.

See https://jenkins.softwareheritage.org/job/DAUTH/job/tests-on-diff/53/ for more details.

ok

That will break deposit tests though (i gather you will deal with the webapp ones soon).

Can we keep aliases on old names to avoid the temporary breakage?

ok

That will break deposit tests though (i gather you will deal with the webapp ones soon).

Can we keep aliases on old names to avoid the temporary breakage?

Sure, will update the diff.

Ensure backaward compatibility with old function name

Build is green

Patch application report for D5335 (id=19131)

Rebasing onto b1e0415698...

Current branch diff-target is up to date.
Changes applied before test
commit db5388d38a6a591d0d9d8bc35a440e13f62cac53
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Mar 25 13:52:00 2021 +0100

    tests: Rename keycloak_mock fixture to keycloak_oidc
    
    Let's start to apply recommended guidelines when writing tests.

See https://jenkins.softwareheritage.org/job/DAUTH/job/tests-on-diff/54/ for more details.

This revision is now accepted and ready to land.Mar 25 2021, 2:27 PM