Let's start to apply recommended guidelines when writing tests.
See "Don't give mock/stubs/fakes special names" section.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDAUTHdb5388d38a6a: tests: Rename keycloak_mock fixture to keycloak_oidc
Diff Detail
Diff Detail
- Repository
- rDAUTH Common authentication libraries
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 20213 Build 31370: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 31369: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D5335 (id=19128)
Rebasing onto b1e0415698...
Current branch diff-target is up to date.
Changes applied before test
commit dc33050a245e1d0d78383752fb0827d352f21625
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Thu Mar 25 13:52:00 2021 +0100
tests: Rename keycloak_mock fixture to keycloak_oidc
Let's start to apply recommended guidelines when writing tests.See https://jenkins.softwareheritage.org/job/DAUTH/job/tests-on-diff/53/ for more details.
Comment Actions
ok
That will break deposit tests though (i gather you will deal with the webapp ones soon).
Can we keep aliases on old names to avoid the temporary breakage?
Comment Actions
Build is green
Patch application report for D5335 (id=19131)
Rebasing onto b1e0415698...
Current branch diff-target is up to date.
Changes applied before test
commit db5388d38a6a591d0d9d8bc35a440e13f62cac53
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Thu Mar 25 13:52:00 2021 +0100
tests: Rename keycloak_mock fixture to keycloak_oidc
Let's start to apply recommended guidelines when writing tests.See https://jenkins.softwareheritage.org/job/DAUTH/job/tests-on-diff/54/ for more details.