Page MenuHomeSoftware Heritage
Differential D616

Migrate from nose to pytest and add tox.ini
ClosedPublic
Actions

Authored by anlambert on Oct 26 2018, 10:36 PM.

Details

Reviewers
douardda
olasd
Group Reviewers
Reviewers
Commits
R65:66b363135348: tox: Fix deprecation warnings
R65:8bfcb3a037f7: tests: Enable to run unit tests without static assets generated
R65:5468c762651d: tests: Migrate from nose to pytest
R65:30700b6e96c6: tests: Add tox.ini file
rDWAPPS8bfcb3a037f7: tests: Enable to run unit tests without static assets generated
rDWAPPS66b363135348: tox: Fix deprecation warnings
rDWAPPS30700b6e96c6: tests: Add tox.ini file
rDWAPPS5468c762651d: tests: Migrate from nose to pytest
Summary

Migrate swh-web tests from nose to pytest.

The good news is that thanks to pytest-django, we benefit from the same tests features
as when using the command $ python3 manage.py test: automatic migrations, in-memory
database, ... This greatly simplifies the tests setup.

Also add tox.ini and fix deprecation warnings printed by the latest pytest version
available on PyPI.

Related T1261
Related T1247

Diff Detail

Repository
rDWAPPS Web applications
Branch
pytest-tox
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1977
Build 2390: tox-on-jenkinsJenkins
Build 2389: arc lint + arc unit

Event Timeline

anlambert created this revision.Oct 26 2018, 10:36 PM
anlambert added a reviewer: Reviewers.Oct 26 2018, 10:37 PM
swh-public-ci added a subscriber: swh-public-ci.Oct 26 2018, 10:39 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/14/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/14/console

Harbormaster failed remote builds in B1963: Diff 1875!Oct 26 2018, 10:39 PM
anlambert added a comment.EditedOct 26 2018, 10:44 PM

tox build on jenkins currently fails as static assets have not been generated. The following command must be executed before running tox: $ npm install && npm run build-dev

ardumont added a subscriber: ardumont.Oct 26 2018, 11:04 PM

sounds good.
I'll let other review though ;)

anlambert updated this revision to Diff 1892.Oct 29 2018, 11:26 AM

Update diff in order to run the Python unit tests without the generation of
static assets through webpack.

swh-public-ci added a comment.Oct 29 2018, 11:28 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/15/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/15/console

Harbormaster failed remote builds in B1977: Diff 1892!Oct 29 2018, 11:28 AM
anlambert updated this revision to Diff 1893.Oct 29 2018, 11:34 AM

Jenkins build should be green after this update.

swh-public-ci added a comment.Oct 29 2018, 11:36 AM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/16/ for more details.

Harbormaster completed remote builds in B1978: Diff 1893.Oct 29 2018, 11:36 AM
olasd accepted this revision.Oct 29 2018, 1:45 PM
olasd added a subscriber: olasd.

Neat trick with the assets stuff! I can confirm that make test looks happy in my setup.

pytest.ini
4

Meh.

This revision is now accepted and ready to land.Oct 29 2018, 1:45 PM
anlambert marked an inline comment as done.Oct 29 2018, 2:14 PM
anlambert added inline comments.
pytest.ini
4

For the record, this was to filter out a deprecation warnings in docutils:

.tox/py3/lib/python3.5/site-packages/swh/web/tests/common/test_templatetags.py::SWHTemplateTagsTest::test_safe_docstring_display
  /home/antoine/swh/swh-environment/swh-web/.tox/py3/lib/python3.5/site-packages/docutils/io.py:245: DeprecationWarning: 'U' mode is deprecated
    self.source = open(source_path, mode, **kwargs)

Fortunately, pytest enables to filter out some warnings in a per test basis through a decorator (https://docs.pytest.org/en/latest/warnings.html#pytest-mark-filterwarnings). So I will use it in the corresponding test instead of using a global warnings filter.

anlambert updated this revision to Diff 1895.Oct 29 2018, 2:18 PM

Small update: use @pytest.mark.filterwarnings decorator to filter out
a deprecation warning related to docutils in the corresponding test
instead of using a global warnings filter.

swh-public-ci added a comment.Oct 29 2018, 2:21 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/17/ for more details.

Harbormaster completed remote builds in B1980: Diff 1895.Oct 29 2018, 2:21 PM
Closed by commit rDWAPPS5468c762651d: tests: Migrate from nose to pytest (authored by anlambert). · Explain WhyOct 29 2018, 2:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
2 lines
3 lines
6 lines
debian/
3 lines
6 lines
6 lines
4 lines
swh/
web/
browse/
6 lines
common/
4 lines
settings/
6 lines
tests/
13 lines
admin/
92 lines
api/
18 lines
views/
152 lines
24 lines
18 lines
8 lines
54 lines
12 lines
12 lines
18 lines
136 lines
30 lines
24 lines
24 lines
browse/
views/
28 lines
6 lines
16 lines
34 lines
4 lines
6 lines
16 lines
common/
26 lines
74 lines
16 lines
56 lines
16 lines
6 lines
40 lines
18 lines

Diff 1892

View Options

.gitignore

Loading...
View Options

MANIFEST.in

Loading...
View Options

Makefile.local

Loading...
View Options

debian/control

Loading...
View Options

debian/rules

Loading...
View Options

pytest.ini

Loading...
View Options

requirements-test.txt

Loading...
View Options

swh/web/browse/utils.py

Loading...
View Options

swh/web/common/utils.py

Loading...
View Options

swh/web/settings/tests.py

Loading...
View Options

swh/web/tests/__init__.py

Loading...
View Options

swh/web/tests/admin/test_origin_save.py

Loading...
View Options

swh/web/tests/api/test_apiresponse.py

Loading...
View Options

swh/web/tests/api/views/test_content.py

Loading...
View Options

swh/web/tests/api/views/test_directory.py

Loading...
View Options

swh/web/tests/api/views/test_entity.py

Loading...
View Options

swh/web/tests/api/views/test_identifiers.py

Loading...
View Options

swh/web/tests/api/views/test_origin.py

Loading...
View Options

swh/web/tests/api/views/test_origin_save.py

Loading...
View Options

swh/web/tests/api/views/test_person.py

Loading...
View Options

swh/web/tests/api/views/test_release.py

Loading...
View Options

swh/web/tests/api/views/test_revision.py

Loading...
View Options

swh/web/tests/api/views/test_snapshot.py

Loading...
View Options

swh/web/tests/api/views/test_stat.py

Loading...
View Options

swh/web/tests/api/views/test_vault.py

Loading...
View Options

swh/web/tests/browse/views/test_content.py

Loading...
View Options

swh/web/tests/browse/views/test_directory.py

Loading...
View Options

swh/web/tests/browse/views/test_identifiers.py

Loading...
View Options

swh/web/tests/browse/views/test_origin.py

Loading...
View Options

swh/web/tests/browse/views/test_person.py

Loading...
View Options

swh/web/tests/browse/views/test_release.py

Loading...
View Options

swh/web/tests/browse/views/test_revision.py

Loading...
View Options

swh/web/tests/common/test_converters.py

Loading...
View Options

swh/web/tests/common/test_highlightjs.py

Loading...
View Options

swh/web/tests/common/test_query.py

Loading...
View Options

swh/web/tests/common/test_service.py

Loading...
View Options

swh/web/tests/common/test_templatetags.py

Loading...
View Options

swh/web/tests/common/test_utils.py

Loading...
View Options

swh/web/tests/conftest.py

Loading...
View Options

tox.ini

Loading...
About · Developer information · Legal