Differential D5174

scanner: Use CoreSWHID instead of the deprecated SWHID class.
ClosedPublic
Actions

Authored by vlorentz on Mar 1 2021, 4:49 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDTSCN3c3bdf5aa6b6: Use CoreSWHID instead of the deprecated SWHID class.

Test Plan

Tests were already failing prior to this commit for a reason I don't understand

Diff Detail

Repository

rDTSCN Code scanner

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 19576
Build 30379: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 30378: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	3 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.scanner.tests.test_scanner::test_scanner_get_subpaths temp_folder = {'filesample': PosixPath('/tmp/pytest-of-jenkins/pytest-0/test_scanner_get_subpaths0/subdir/filesample.txt'), 'filesam...9a060e54bf8d69288fbee4904', ...}, 'root': PosixPath('/tmp/pytest-of-jenkins/pytest-0/test_scanner_get_subpaths0'), ...} def test_scanner_get_subpaths(temp_folder):
	3 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.scanner.tests.test_scanner::test_scanner_raise_apierror_input_size_limit event_loop = <_UnixSelectorEventLoop running=False closed=False debug=False> aiosession = <aiohttp.client.ClientSession object at 0x7f0f40b55940> live_server = <[AttributeError("'LiveServer' object has no attribute 'url'") raised in repr()] LiveServer object at 0x7f0f40b4c940>
	6 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.scanner.tests.test_scanner::test_scanner_result live_server = <[AttributeError("'LiveServer' object has no attribute 'url'") raised in repr()] LiveServer object at 0x7f0f40b4c940> event_loop = <_UnixSelectorEventLoop running=False closed=False debug=False> test_sample_folder = PosixPath('/tmp/pytest-of-jenkins/pytest-0/test_scanner_result0/sample-folder')
	6 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.scanner.tests.test_scanner::test_scanner_result_with_exclude_patterns live_server = <[AttributeError("'LiveServer' object has no attribute 'url'") raised in repr()] LiveServer object at 0x7f0f40b4c940> event_loop = <_UnixSelectorEventLoop running=False closed=False debug=False> test_sample_folder = PosixPath('/tmp/pytest-of-jenkins/pytest-0/test_scanner_result_with_exclu0/sample-folder')
	149 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.scanner.tests.test_backend::test_backend_endpoint_all_present
		View Full Test Results (4 Failed · 31 Passed)

Event Timeline

vlorentz created this revision.Mar 1 2021, 4:49 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 1 2021, 4:49 PM

Build has FAILED

Patch application report for D5174 (id=18499)

Rebasing onto ed7a9706e5...

Current branch diff-target is up to date.

Changes applied before test

commit 3c3bdf5aa6b60d4e4cbadefaff368e1e8bcc846a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Mar 1 16:48:39 2021 +0100

    Use CoreSWHID instead of the deprecated SWHID class.

Link to build: https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/101/
See console output for more information: https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/101/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 1 2021, 4:52 PM

Harbormaster failed remote builds in B19576: Diff 18499!

vlorentz requested review of this revision.Mar 1 2021, 5:01 PM

lgtm

might be best to fix master prior to land this though (in another diff).

ardumont accepted this revision.Mar 1 2021, 5:44 PM

This revision is now accepted and ready to land.Mar 1 2021, 5:44 PM

This revision was landed with ongoing or failed builds.Mar 1 2021, 5:45 PM

Closed by commit rDTSCN3c3bdf5aa6b6: Use CoreSWHID instead of the deprecated SWHID class. (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDTSCN3c3bdf5aa6b6: Use CoreSWHID instead of the deprecated SWHID class..