Differential D5174

scanner: Use CoreSWHID instead of the deprecated SWHID class.
ClosedPublic
Actions

Authored by vlorentz on Mar 1 2021, 4:49 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDTSCN3c3bdf5aa6b6: Use CoreSWHID instead of the deprecated SWHID class.

Test Plan

Tests were already failing prior to this commit for a reason I don't understand

Diff Detail

Repository

rDTSCN Code scanner

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Mar 1 2021, 4:49 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 1 2021, 4:49 PM

Build has FAILED

Patch application report for D5174 (id=18499)

Rebasing onto ed7a9706e5...

Current branch diff-target is up to date.

Changes applied before test

commit 3c3bdf5aa6b60d4e4cbadefaff368e1e8bcc846a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Mar 1 16:48:39 2021 +0100

    Use CoreSWHID instead of the deprecated SWHID class.

Link to build: https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/101/
See console output for more information: https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/101/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 1 2021, 4:52 PM

Harbormaster failed remote builds in B19576: Diff 18499!

vlorentz requested review of this revision.Mar 1 2021, 5:01 PM

lgtm

might be best to fix master prior to land this though (in another diff).

ardumont accepted this revision.Mar 1 2021, 5:44 PM

This revision is now accepted and ready to land.Mar 1 2021, 5:44 PM

This revision was landed with ongoing or failed builds.Mar 1 2021, 5:45 PM

Closed by commit rDTSCN3c3bdf5aa6b6: Use CoreSWHID instead of the deprecated SWHID class. (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDTSCN3c3bdf5aa6b6: Use CoreSWHID instead of the deprecated SWHID class..

In D5174#130964, @ardumont wrote:

lgtm

might be best to fix master prior to land this though (in another diff).

D5178

Revision Contents
Changeset List

Path

Size

swh/

scanner/

scanner.py

14 lines

Diff 18513

View Options

scanner: Use CoreSWHID instead of the deprecated SWHID class.ClosedPublicActions