Fix usage of detect_metadata
ClosedPublic
Actions

Authored by vlorentz on Oct 25 2018, 3:23 PM.

Details

Reviewers

Summary

Fix non-deterministic bug caused by detect_metadata receiving a generator that's sent to multiple functions in non-det order.

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

nondet-indexer-bug

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1912
Build 2302: arc lint + arc unit

Event Timeline

vlorentz created this revision.Oct 25 2018, 3:23 PM

Harbormaster completed remote builds in B1912: Diff 1830.Oct 25 2018, 3:23 PM

@moranegg that's the fix for "your" bug :)

as discussed, fix the caller, not the detect_metadata function

This revision now requires changes to proceed.Oct 25 2018, 3:42 PM

Better fix.

Harbormaster completed remote builds in B1913: Diff 1832.Oct 25 2018, 3:42 PM

douardda accepted this revision.Oct 25 2018, 5:22 PM

This revision is now accepted and ready to land.Oct 25 2018, 5:22 PM

vlorentz retitled this revision from Fix non-deterministic bug caused by detect_metadata receiving a generator that's sent to multiple functions in non-det order. to Fix usage of detect_metadata.Oct 25 2018, 6:22 PM

vlorentz edited the summary of this revision. (Show Details)

ardumont mentioned this in rDCIDXcbf58b593544: Fix usage of detect_metadata.Oct 25 2018, 6:47 PM

Merged by @ardumont

Revision Contents
Changeset List

Path

Size

swh/

indexer/

metadata_detector.py

1 line

Diff 1830

View Options

swh/indexer/metadata_detector.py

Fix usage of detect_metadataClosedPublicActions