Page MenuHomeSoftware Heritage
Differential D5080

Add a pre-commit config file
ClosedPublic
Actions

Authored by douardda on Feb 16 2021, 10:38 AM.

Details

Reviewers
aeviso
Group Reviewers
Reviewers
Commits
rDPROV48b9b0354d40: Blackify, isort and fix code spells reported by pre-commit hooks
rDPROV01b290e9a7c8: Add a pre-commit config file
Summary

Blackify, isort and fix code spells reported by pre-commit hooks

Diff Detail

Repository
rDPROV Provenance database
Branch
refactorings
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 19354
Build 30012: arc lint + arc unit

Event Timeline

douardda requested review of this revision.Feb 16 2021, 10:38 AM
douardda created this revision.
Harbormaster completed remote builds in B19237: Diff 18133.Feb 16 2021, 10:38 AM
douardda mentioned this in D5072: Refactor the db scaffolding to use swh.core.db.Feb 16 2021, 10:39 AM
douardda added a child revision: D5072: Refactor the db scaffolding to use swh.core.db.Feb 16 2021, 10:40 AM
douardda added reviewers: aeviso, Reviewers.Feb 16 2021, 10:56 AM
vlorentz added a subscriber: vlorentz.Feb 16 2021, 12:24 PM
vlorentz added inline comments.
.pre-commit-config.yaml
29

that's no excuse for a new package!

douardda updated this revision to Diff 18147.Feb 16 2021, 3:42 PM

add missing isort config in pyproject.toml

Harbormaster completed remote builds in B19251: Diff 18147.Feb 16 2021, 3:42 PM
douardda added inline comments.Feb 16 2021, 4:56 PM
.pre-commit-config.yaml
29

I guess you are right... stupid copy/paste

douardda added inline comments.Feb 16 2021, 5:13 PM
.pre-commit-config.yaml
29

actually it's probably not an excuse for other packages either, since this is checked against modified stuff only... probably a good thing to activate everywhere to have a chance of converging (aka have docstrings more or less everywhere) in a finite time...

douardda updated this revision to Diff 18155.Feb 16 2021, 5:32 PM

ad forgotten isorts (after proper config in pyproject.toml)

Harbormaster completed remote builds in B19259: Diff 18155.Feb 16 2021, 5:32 PM
aeviso accepted this revision.Feb 18 2021, 10:59 AM
This revision is now accepted and ready to land.Feb 18 2021, 10:59 AM
douardda updated this revision to Diff 18258.Feb 18 2021, 5:40 PM

rebase

Harbormaster completed remote builds in B19354: Diff 18258.Feb 18 2021, 5:40 PM
Closed by commit rDPROV01b290e9a7c8: Add a pre-commit config file (authored by douardda). · Explain WhyFeb 18 2021, 5:40 PM
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDPROV01b290e9a7c8: Add a pre-commit config file.
douardda added a commit: rDPROV48b9b0354d40: Blackify, isort and fix code spells reported by pre-commit hooks.

Revision Contents
Changeset List

PathSize
48 lines
10 lines
6 lines
swh/
provenance/
4 lines
4 lines
8 lines
postgresql/
12 lines
4 lines
8 lines
2 lines
postgresql_nopath/
6 lines
2 lines
9 lines
7 lines
storage/
6 lines

Diff 18258

View Options

.pre-commit-config.yaml

Loading...
View Options

pyproject.toml

Loading...
View Options

setup.py

Loading...
View Options

swh/provenance/__init__.py

Loading...
View Options

swh/provenance/cli.py

Loading...
View Options

swh/provenance/origin.py

Loading...
View Options

swh/provenance/postgresql/archive.py

Loading...
View Options

swh/provenance/postgresql/db_utils.py

Loading...
View Options

swh/provenance/postgresql/provenance.py

Loading...
View Options

swh/provenance/postgresql/provenance.sql

Loading...
View Options

swh/provenance/postgresql_nopath/provenance.py

Loading...
View Options

swh/provenance/postgresql_nopath/provenance.sql

Loading...
View Options

swh/provenance/provenance.py

Loading...
View Options

swh/provenance/revision.py

Loading...
View Options

swh/provenance/storage/archive.py

Loading...
About · Developer information · Legal