Differential D4886

Import the journal subcommand in the main swh.scheduler cli
ClosedPublic
Actions

Authored by vlorentz on Jan 19 2021, 6:03 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSCH98526539a8e4: Import the journal subcommand in the main swh.scheduler cli

Summary

This issue was masked by tox.ini using pytest with --doctest-modules,
which imports all modules during test collection, and therefore executing
the side-effects of swh.scheduler.cli.journal.

Test Plan

"it works on my machine" (run pytest without --doctest-modules)

Diff Detail

Repository

rDSCH Scheduling utilities

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18510
Build 28631: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 28630: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jan 19 2021, 6:03 PM

Build is green

Patch application report for D4886 (id=17353)

Rebasing onto 0a32a31195...

First, rewinding head to replay your work on top of it...
Applying: Import the journal subcommand in the main swh.scheduler cli

Changes applied before test

commit b81a1f2460c209b0d7c612315290fe0233285e9f
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Jan 19 17:56:44 2021 +0100

    Import the journal subcommand in the main swh.scheduler cli
    
    This issue was masked by tox.ini using pytest with --doctest-modules,
    which imports all modules during test collection, and therefore executing
    the side-effects of swh.scheduler.cli.journal.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/164/ for more details.

Harbormaster completed remote builds in B18490: Diff 17353.Jan 19 2021, 6:05 PM

vlorentz requested review of this revision.Jan 19 2021, 6:05 PM

vlorentz mentioned this in D4856: Introduce scaffolding for a scheduler simulator.Jan 19 2021, 6:05 PM

Thanks.

This revision is now accepted and ready to land.Jan 20 2021, 9:35 AM

Rebase

Build is green

Patch application report for D4886 (id=17374)

Rebasing onto f8627a96fe...

Current branch diff-target is up to date.

Changes applied before test

commit 98526539a8e4fe8a002e5b32370bfc12bc7dc2e7
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Jan 19 17:56:44 2021 +0100

    Import the journal subcommand in the main swh.scheduler cli
    
    This issue was masked by tox.ini using pytest with --doctest-modules,
    which imports all modules during test collection, and therefore executing
    the side-effects of swh.scheduler.cli.journal.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/177/ for more details.

Harbormaster completed remote builds in B18510: Diff 17374.Jan 20 2021, 10:38 AM

Closed by commit rDSCH98526539a8e4: Import the journal subcommand in the main swh.scheduler cli (authored by olasd, committed by vlorentz). · Explain WhyJan 20 2021, 10:47 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSCH98526539a8e4: Import the journal subcommand in the main swh.scheduler cli.