The --slug behavior is marked as deprecated but still usable. The new --create-origin
flag allows to generate the proper xml stanza when the client does not provide any
metadata xml file.
Related to T2860
Differential D4834
deposit.client.cli: Expose --create-origin flag and deprecate --slug ardumont on Jan 11 2021, 2:00 PM. Authored by Tags None Subscribers None
Details
The --slug behavior is marked as deprecated but still usable. The new --create-origin Related to T2860 tox
Diff Detail
Event TimelineComment Actions Build is green Patch application report for D4834 (id=17126)Rebasing onto 83a5ded409... Current branch diff-target is up to date. Changes applied before testcommit fecd951e9d0ea1d8ead230ab4d1a1deb0fa85743 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Mon Jan 11 13:58:04 2021 +0100 deposit.client.cli: Expose --create-origin flag and deprecate --slug Related to T2860 See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/519/ for more details. Comment Actions
Comment Actions Build is green Patch application report for D4834 (id=17145)Rebasing onto 82a26b5e86... Current branch diff-target is up to date. Changes applied before testcommit 40e04b73519a74eada25844fdf3375bd8bdbaab4 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Mon Jan 11 13:58:04 2021 +0100 deposit.client.cli: Expose --create-origin flag and deprecate --slug The --slug behavior is marked as deprecated but still usable. The new --create-origin flag allows to generate the proper xml stanza when the client does not provide any metadata xml file. Related to T2860 See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/521/ for more details. Comment Actions Build is green Patch application report for D4834 (id=17146)Rebasing onto 82a26b5e86... Current branch diff-target is up to date. Changes applied before testcommit 565bb8fefeeb25acb03fbc5be780e8a14a191b4f Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Mon Jan 11 13:58:04 2021 +0100 deposit.client.cli: Expose --create-origin flag and deprecate --slug The --slug behavior is marked as deprecated but still usable. The new --create-origin flag allows to generate the proper xml stanza when the client does not provide any metadata xml file. Related to T2860 See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/522/ for more details.
Comment Actions Drop duplicated xmlns:codemeta header introduced by mistake (that must have been my initial attempt to add the xmlns:swh header which started as a
Comment Actions Build is green Patch application report for D4834 (id=17203)Rebasing onto 82a26b5e86... Current branch diff-target is up to date. Changes applied before testcommit 89fa88ab697afc8d0c2e6d2654cf91a81638ab86 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Mon Jan 11 13:58:04 2021 +0100 deposit.client.cli: Expose --create-origin flag and deprecate --slug The --slug behavior is marked as deprecated but still usable. The new --create-origin flag allows to generate the proper xml stanza when the client does not provide any metadata xml file. Related to T2860 See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/523/ for more details. Comment Actions Build is green Patch application report for D4834 (id=17211)Rebasing onto 38788d907c... Current branch diff-target is up to date. Changes applied before testcommit 2c47667ab6257aed298baff0330a6e5ee1e0ac26 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Mon Jan 11 13:58:04 2021 +0100 deposit.client.cli: Expose --create-origin flag and deprecate --slug The --slug behavior is marked as deprecated but still usable. The new --create-origin flag allows to generate the proper xml stanza when the client does not provide any metadata xml file. Related to T2860 See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/527/ for more details. Comment Actions That diff annoyed me a bit. It felt incomplete so far without pinpointing exactly the issue. It deprecates the --slug behavior by telling it as much through a warning. So the behavior is kept. That's what feels incomplete. That leaves totally alone the current users which do provide their xml. any thought on whether we want to take care of this at all? And if so, how to properly do it? Thanks for the input. Cheers, Comment Actions You can make an other diff to make the client parse the XML and check if there is <swh:create_origin>/<swh:add_to_origin> in it; and show a warning if there isn't. Comment Actions
sounds good, thanks. |