Differential D4548

requirements-test.txt: Drop no longer needed pytest-postgresql requirement
ClosedPublic
Actions

Authored by ardumont on Nov 20 2020, 5:17 PM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Maniphest Tasks

T2746: packaging: Split swh.core and test dependencies properly

Commits

rDSCH49ed8194bf74: requirements-test.txt: Drop no longer needed pytest-postgresql requirement

Summary

requirements-swh.txt already declares the swh.core[db] dependency which
transitively pulls it.

Related to T2746

(That still needs some work on the debian front)

Test Plan

tox

Diff Detail

Repository

rDSCH Scheduling utilities

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17345
Build 26792: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 26791: arc lint + arc unit

Event Timeline

ardumont created this revision.Nov 20 2020, 5:17 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 20 2020, 5:17 PM

Build is green

Patch application report for D4548 (id=16145)

Rebasing onto 2f9e8ec122...

Current branch diff-target is up to date.

Changes applied before test

commit b4b921234b813bdd2c368fce92322d8ef2c43f10
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Nov 20 17:17:14 2020 +0100

    requirements-test.txt: Drop no longer needed pytest-postgresql requirement
    
    requirements-swh.txt already declares the swh.core[db] dependency which
    transitively pulls it.
    
    Related to T2746

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/73/ for more details.

Harbormaster completed remote builds in B17344: Diff 16145.Nov 20 2020, 5:18 PM

ardumont added inline comments.Nov 20 2020, 5:18 PM

requirements-test.txt
3	wondering if i need to drop it entirely as i did here or if i need to replace it with swh.core[db] or swh.core[testing] (both would pull pytest-postgresql afaiui with D4543)

Be explicit instead of implying dependency

ardumont added inline comments.Nov 20 2020, 5:23 PM

requirements-test.txt
3	well, i preferred being explicit it and conservative on the deps to pull so I chose to replace pytest-postgresql by swh.core[db]

Build is green

Patch application report for D4548 (id=16146)

Rebasing onto 2f9e8ec122...

Current branch diff-target is up to date.

Changes applied before test

commit 6d38934ebb38bc65bc30c1c6edcb438acad41682
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Nov 20 17:17:14 2020 +0100

    requirements-test.txt: Explicit swh.core[db] as test requirement
    
    instead of pytest-postgresql which is a transitive dependency from swh.core[db]
    
    Related to T2746

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/74/ for more details.

Harbormaster completed remote builds in B17345: Diff 16146.Nov 20 2020, 5:23 PM

ardumont mentioned this in D4549: requirements-test.txt: Drop no longer needed pytest-postgresql requirement.Nov 20 2020, 5:24 PM

ardumont mentioned this in D4550: requirements-test.txt: Explicit swh.core[db] as test requirement.

ardumont edited the summary of this revision. (Show Details)Nov 20 2020, 5:26 PM

ardumont mentioned this in D4554: requirements-test.txt: Drop no longer needed test dependency.Nov 23 2020, 11:20 AM

douardda accepted this revision.Nov 23 2020, 12:36 PM

This revision is now accepted and ready to land.Nov 23 2020, 12:36 PM

Drop dependency instead

Build is green

Patch application report for D4548 (id=16185)

Rebasing onto 2f9e8ec122...

Current branch diff-target is up to date.

Changes applied before test

commit 49ed8194bf74233888f841768f234d1dc3a31243
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Nov 20 17:17:14 2020 +0100

    requirements-test.txt: Drop no longer needed pytest-postgresql requirement
    
    requirements-swh.txt already declares the swh.core[db] dependency which
    transitively pulls it.
    
    Related to T2746

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/76/ for more details.

Harbormaster completed remote builds in B17385: Diff 16185.Nov 23 2020, 1:13 PM

Closed by commit rDSCH49ed8194bf74: requirements-test.txt: Drop no longer needed pytest-postgresql requirement (authored by ardumont). · Explain WhyNov 23 2020, 1:24 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSCH49ed8194bf74: requirements-test.txt: Drop no longer needed pytest-postgresql requirement.