Differential D4377

Simplify the scheduler's database initialization
ClosedPublic
Actions

Authored by vsellier on Oct 29 2020, 10:00 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2736: Configure db1 as new staging db server

Commits

rDENV2a5d9a2776dd: Simplify the scheduler's database initialization

Summary

Use the new "init-admin" command to initialize the database and fallback to the standard postgresql initialization.
The database creation is delegated to the postgresql entrypoint, the extensions and the tables are configured respectively by the init-admin and init commands.

Using this, we can execute the "init-admin" command at each start which can be useful when new super-user migrations are added.

Example of a restart:

swh-scheduler_1                 | Creating extensions...
swh-scheduler_1                 | psql:/srv/softwareheritage/venv/lib/python3.7/site-packages/swh/scheduler/sql/10-superuser-init.sql:1: NOTICE:  extension "uuid-ossp" already exists, skipping
swh-scheduler_1                 | Initializing the database...
swh-scheduler_1                 | DONE database for scheduler exists at version 17
swh-scheduler_1                 | Starting the swh-scheduler API server

Related to T2736
Depends on D4374

Test Plan

with the diff applied on core + the docker-compose.override.yml well configured to use the core module

docker-compose down -v
docker-compose up swh-scheduler-db
docker-compose down
docker-compose up swh-scheduler

Diff Detail

Repository

rDENV Development environment

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16708
Build 25764: arc lint + arc unit

Event Timeline

vsellier created this revision.Oct 29 2020, 10:00 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 29 2020, 10:00 AM

Harbormaster completed remote builds in B16708: Diff 15482.Oct 29 2020, 10:00 AM

ardumont mentioned this in D4374: cli.db: Open init-admin subcmd to initialize superuser-level scripts.Oct 29 2020, 10:01 AM

This is a poc for the scheduler, all the databases initialization could be changed this way when the diff on swh-core will land.

ardumont edited the test plan for this revision. (Show Details)Oct 29 2020, 10:02 AM

Using this, we can execute the "init-admin" command at each start so new superuser scripts can be executed during each restart toUsing this, we can execute the "init-admin" command at each start which can be useful when new super-user migrations are added

Example of a restart:

swh-scheduler_1                 | Creating extensions...
swh-scheduler_1                 | psql:/srv/softwareheritage/venv/lib/python3.7/site-packages/swh/scheduler/sql/10-superuser-init.sql:1: NOTICE:  extension "uuid-ossp" already exists, skipping
swh-scheduler_1                 | Initializing the database...
swh-scheduler_1                 | DONE database for scheduler exists at version 17
swh-scheduler_1                 | Starting the swh-scheduler API server

vsellier edited the summary of this revision. (Show Details)Oct 29 2020, 10:14 AM

vsellier requested review of this revision.Oct 29 2020, 10:37 AM

olasd added a subscriber: olasd.Oct 29 2020, 10:41 AM

olasd added inline comments.