Page MenuHomeSoftware Heritage

gitlab lister: Fix couple of issues
ClosedPublic

Authored by ardumont on Oct 5 2018, 4:22 PM.

Details

Summary
  • gitlab.lister: Do not expect gitlab instances to have credentials

Only the main gitlab.com instance supports a rate limit (thus the
credentials need), others do not (as per summer 2018, i did not check today).

gitlab.lister: Break asap when problem exists during fetch info step

Prior to this, when wrong url injection happens (and it happened /o\),
no information is fetched. Because we have a bad input in the first place
(either 404 or 400). This makes for a long debugging session...

Test Plan

make test still ok

Diff Detail

Repository
rDLS Listers
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1578
Build 1922: arc lint + arc unit

Event Timeline

ardumont retitled this revision from Fix couple of issues to gitlab lister: Fix couple of issues.Oct 5 2018, 4:22 PM
ardumont added a project: Origin-GitLab.
ardumont edited the summary of this revision. (Show Details)

Rebase

  • gitlab.lister: Do not expect gitlab instances to have credentials
  • gitlab.lister: Break asap when problem exists during fetch info
This revision is now accepted and ready to land.Oct 8 2018, 3:14 PM
This revision was automatically updated to reflect the committed changes.