gitlab lister: Fix couple of issues
ClosedPublic
Actions

Authored by ardumont on Oct 5 2018, 4:22 PM.

Details

Reviewers

Group Reviewers

Commits

rDLS8f5b10b3a319: gitlab.lister: Break asap when problem exists during fetch info
rDLSae514a84c400: gitlab.lister: Do not expect gitlab instances to have credentials

Summary

gitlab.lister: Do not expect gitlab instances to have credentials

Only the main gitlab.com instance supports a rate limit (thus the
credentials need), others do not (as per summer 2018, i did not check today).

gitlab.lister: Break asap when problem exists during fetch info step

Prior to this, when wrong url injection happens (and it happened /o\),
no information is fetched. Because we have a bad input in the first place
(either 404 or 400). This makes for a long debugging session...

Test Plan

make test still ok

Diff Detail

Repository

rDLS Listers

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1554
Build 1898: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 5 2018, 4:22 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 5 2018, 4:22 PM

Harbormaster completed remote builds in B1554: Diff 1496.Oct 5 2018, 4:22 PM

ardumont retitled this revision from Fix couple of issues to gitlab lister: Fix couple of issues.Oct 5 2018, 4:22 PM

ardumont added a project: Origin-GitLab.

ardumont mentioned this in T1243: lister gitlab: Ingest inria forge instance.Oct 5 2018, 4:30 PM

ardumont edited the summary of this revision. (Show Details)Oct 5 2018, 6:27 PM

Rebase

gitlab.lister: Do not expect gitlab instances to have credentials
gitlab.lister: Break asap when problem exists during fetch info

Harbormaster completed remote builds in B1578: Diff 1538.Oct 8 2018, 1:56 PM

olasd accepted this revision.Oct 8 2018, 3:14 PM

This revision is now accepted and ready to land.Oct 8 2018, 3:14 PM

Closed by commit rDLSae514a84c400: gitlab.lister: Do not expect gitlab instances to have credentials (authored by ardumont). · Explain WhyOct 8 2018, 3:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

lister/

gitlab/

lister.py

11 lines

Diff 1496

View Options

swh/lister/gitlab/lister.py

gitlab lister: Fix couple of issuesClosedPublicActions